-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support building this repo for more platforms, by checking the build triple #1294
Conversation
2820bd9
to
04b4432
Compare
if cross_compile: | ||
cross_compile_json = json.load(open(args.cross_compile_config)) | ||
command += ['-target', cross_compile_json["target"]] | ||
target_info_json = subprocess.check_output(command, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I copied this over from my earlier change to the SPM bootstrap script.
2fb749b
to
a128b82
Compare
Updated this pull with build script changes to allow cross-compiling to Android on macOS: @artemcm, let me know what you think of the build script changes alone for now. |
@artemcm, now that this passed the CI on the linked compiler pull, looking for review so I can get this in before the upcoming 5.9 branch. Please don't merge though, as all 11 pulls will have to be merged together. |
…triple This replaces all but one prior check of the host system instead, plus removed unnecessary regex checking.
Removed the architecture-specific changes since the Swift devs want to take a different approach, leaving only these build script modifications I had also made. One last CI run and this can go in, @artemcm. |
Ping @artemcm, this pull look okay to you? |
@swift-ci test |
Passed all CI, ready for merge. |
This is needed for all platforms that don't have multi-architecture libraries like Darwin. Also, add the new architecture-specific rpath to the resulting swift-driver and make it possible to cross-compile this repo for non-Darwin platforms on Darwin.The driver changes are the Swift translation of the Driver-specific changes of swiftlang/swift#63782.Resolves apple swift#63645This replaces all but one prior check of the host system instead, plus removed
unnecessary regex checking.