New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build URL logic #20

Open

jclay wants to merge 2 commits into switch-ch:master from jclay:master

jclay commented May 2, 2019

There was a mistake in the build URL logic pointed out in #15 where there is a check done on whether the URL already contains a ? or not.

I have fixed that issue, and cleaned up the related code. Since there's not a test framework, I have tested locally:

var loginUrl = "htts://example.com/?test=1&param=2"
var hasExistingParams = loginUrl.indexOf('?') !== -1;
hasExistingParams
=> true

var loginUrl = "htts://example.com/"
var hasExistingParams = loginUrl.indexOf('?') !== -1;
hasExistingParams
=> false

jclay added 2 commits

May 2, 2019 15:51


          fix build url login logic

13a4f75


          improved formatting of returned data

522b121

rs22 mentioned this pull request

OpenID Connect Login Provider sandstorm-io/sandstorm#3452

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet