-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(WIP) Add message template content as activity #34
Open
jofranz
wants to merge
2
commits into
master
Choose a base branch
from
33-message_template_content_as_activity
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,19 +1,26 @@ | ||
site_name: Birthdays | ||
repo_url: https://github.com/systopia/de.systopia.birthdays | ||
theme: material | ||
site_description: 'Provides a report on upcoming birthdays and an API for sending birthday greetings via e-mail.' | ||
site_author: 'SYSTOPIA' | ||
theme: | ||
name: material | ||
|
||
pages: | ||
- Home: index.md | ||
nav: | ||
- 'Introduction': index.md | ||
|
||
markdown_extensions: | ||
- attr_list | ||
- admonition | ||
- def_list | ||
- codehilite | ||
- toc: | ||
permalink: true | ||
- pymdownx.superfences | ||
- pymdownx.inlinehilite | ||
- pymdownx.tilde | ||
- pymdownx.betterem | ||
- pymdownx.mark | ||
- attr_list | ||
- admonition | ||
- def_list | ||
- codehilite | ||
- toc: | ||
permalink: True | ||
- pymdownx.superfences | ||
- pymdownx.inlinehilite | ||
- pymdownx.tilde | ||
- pymdownx.betterem | ||
- pymdownx.mark | ||
|
||
plugins: | ||
- search: | ||
lang: en |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jensschuppe Is there a example implementation in one of our extensions to fill tokens with content as V3 API is doing it automatically using
MessageTemplate::send
in my previous implementation?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
API3's
MessageTemplate.send
doesn't return the result, butCRM_Core_BAO_MessageTemplate::sendTemplate()
, which basically does all the work inside it, does. So maybe it'd be worth not using the API but this method for getting the contents for passing it into the creation of an activity. You might have to adjust parameters, so check whatcivicrm_api3_message_template_send()
is doing before.Rendering the template a second time for creating the activity doesn't seem to make sense to me.