Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid Call to a member function getProfile() on null errors during contribution validation #159

Merged
merged 1 commit into from
Sep 4, 2023
Merged

Avoid Call to a member function getProfile() on null errors during contribution validation #159

merged 1 commit into from
Sep 4, 2023

Conversation

jensschuppe
Copy link
Collaborator

Fixes #147

Untested.

@jensschuppe jensschuppe requested a review from bjendres February 7, 2023 14:11
@jensschuppe jensschuppe added bug status:needs review Code needs review and testing. labels Feb 7, 2023
@jensschuppe jensschuppe mentioned this pull request Feb 7, 2023
Closed
@bjendres
Copy link
Member

bjendres commented Feb 8, 2023

looks good to me, see #147 (comment)

@jensschuppe jensschuppe added status:reviewed and tested Code has received thorough review and testing and is ready to be committed/merged. and removed status:needs review Code needs review and testing. labels Sep 4, 2023
@jensschuppe jensschuppe added this to the 2.2 milestone Sep 4, 2023
@jensschuppe jensschuppe merged commit c797d69 into master Sep 4, 2023
@jensschuppe jensschuppe added status:fixed The issue has been resolved (usually by committing/merging code). and removed status:reviewed and tested Code has received thorough review and testing and is ready to be committed/merged. labels Sep 4, 2023
@jensschuppe jensschuppe deleted the fix/validateContribution branch September 4, 2023 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjendres bjendres Awaiting requested review from bjendres

Assignees
No one assigned
Labels
bug status:fixed The issue has been resolved (usually by committing/merging code).
Projects
None yet
Milestone
2.2
Development

Successfully merging this pull request may close these issues.

Call to a member function getProfile() on null in CRM_Donrec_Logic_Settings::validateContribution()
2 participants
@jensschuppe @bjendres