Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix array_multisort error #174

Merged
merged 1 commit into from
Sep 18, 2023
Merged

Fix array_multisort error #174

merged 1 commit into from
Sep 18, 2023

Conversation

jensschuppe
Copy link
Collaborator

When opening the Donation Receipts tab on the contact summary, there might be an error due to missing variable initialisation with a default value.

@jensschuppe jensschuppe added bug status:needs review Code needs review and testing. labels Sep 18, 2023
@jensschuppe jensschuppe added this to the 2.3 milestone Sep 18, 2023
bjendres
bjendres approved these changes Sep 18, 2023
View reviewed changes
Copy link
Member

@bjendres bjendres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can't imagine how this could be wrong.

@bjendres bjendres removed the status:needs review Code needs review and testing. label Sep 18, 2023
@jensschuppe jensschuppe added the status:reviewed and tested Code has received thorough review and testing and is ready to be committed/merged. label Sep 18, 2023
@jensschuppe jensschuppe merged commit 485f17b into master Sep 18, 2023
@jensschuppe jensschuppe deleted the array_multisortError branch September 18, 2023 13:28
@jensschuppe jensschuppe added status:fixed The issue has been resolved (usually by committing/merging code). and removed status:reviewed and tested Code has received thorough review and testing and is ready to be committed/merged. labels Sep 18, 2023
@jensschuppe jensschuppe modified the milestones: 2.3, 2.2 Nov 6, 2024
@jensschuppe
Copy link
Collaborator Author

Moved this simple fix to 2.2 and cherry-picked into release/2.2.x.

jensschuppe added a commit that referenced this pull request Nov 6, 2024
@jensschuppe
[#174] Fix array_multisort error
3f964d8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjendres bjendres bjendres approved these changes

Assignees
No one assigned
Labels
bug status:fixed The issue has been resolved (usually by committing/merging code).
Projects
None yet
Milestone
2.2
Development

Successfully merging this pull request may close these issues.
2 participants
@jensschuppe @bjendres