Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace call to deprecated method CRM_Core_BAO_CustomGroup::getTree() #129

Open
jensschuppe opened this issue May 10, 2024 · 1 comment
Open

Replace call to deprecated method CRM_Core_BAO_CustomGroup::getTree() #129

jensschuppe opened this issue May 10, 2024 · 1 comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Milestone
1.0

Comments

@jensschuppe
Copy link
Collaborator 

 ------ --------------------------------------------------------------------------- 
  Line   CRM/Eck/Page/Entity/View.php                                               
 ------ --------------------------------------------------------------------------- 
  88     Call to deprecated method getTree() of class CRM_Core_BAO_CustomGroup:     
         Function demonstrates just how bad code can get from 20 years of entropy.  
 ------ ---------------------------------------------------------------------------

Blocker for stable version 1.0.
@jensschuppe jensschuppe added enhancement New feature or request help wanted Extra attention is needed labels May 10, 2024
@jensschuppe jensschuppe added this to the 1.0 milestone May 10, 2024
@colemanw
Copy link
Collaborator

Looks like that line is part of a quickform... probably the entire form can be replaced with an Afform & then the offending code can be deleted.

jensschuppe added a commit that referenced this issue Feb 17, 2025
@jensschuppe
Add PHPStan baseline for ignoring errors in code that is to be refact…
c0d538a 
…ored

See #129 and #150
@jensschuppe jensschuppe mentioned this issue Feb 17, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
2 participants
@colemanw @jensschuppe