Minor fixups #211
Merged
Minor fixups #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
dvdsk
reviewed
Oct 22, 2024
| @@ -237,7 +239,9 @@ | |||
|
|
|||
| // {% if args.encryption_client_side || args.encryption_server_side || args.enable_readonly %} | |||
| if (passwordField.value.trim() != "") { | |||
| // {% if !args.no_file_upload %} | |||
There was a problem hiding this comment.
same question regarding the other commented bits
There was a problem hiding this comment.
it probably breaks JS parsing in code editors otherwise, and it's processed by the template system anyway.
There was a problem hiding this comment.
ahh thanks (and thanks for the quick response)! I did not know that, I thought they where leftover commented bits from testing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.