Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: check all combinations of internal, external and bounced receivers for "empty" messages #1949

Merged
merged 38 commits into from
Feb 26, 2025

Conversation

jeshecdom
Copy link
Contributor

@jeshecdom jeshecdom commented Feb 21, 2025

Issue

Closes #1849.
Closes #1850.
Closes #1924.
Closes #1918.

For issue #1850, this PR tests it implicitly, because this PR checks all possible combinations of receivers (internal, external and bounced).

This PR sends "empty" messages to receivers:

  • A message with an op code less than 32 bits.
  • An actual empty cell (not even an opcode).
  • A message with opcode 0, but with exactly 32 bits in length.
  • The empty string.
  • An empty string inside a Message struct.
  • An empty message struct.

In the above I said "towards", because this PR is still not checking all possible combinations of bounced receivers.
Bounced receivers are now checked.

Checklist

  • I have updated CHANGELOG.md
  • I have run all the tests locally and no test failure was reported
  • I have run the linter, formatter and spellchecker
  • I did not do unrelated and/or undiscussed refactorings

@novusnota novusnota added this to the v1.6.0 milestone Feb 24, 2025
@jeshecdom jeshecdom changed the title tests: check all combinations of internal and external receivers for "empty" messages tests: check all combinations of internal, external and bounced receivers for "empty" messages Feb 24, 2025
@jeshecdom jeshecdom marked this pull request as ready for review February 24, 2025 17:31
@jeshecdom jeshecdom requested a review from a team as a code owner February 24, 2025 17:31
@anton-trunov
Copy link
Member

let's fix the merge conflicts here and try and merge it

@anton-trunov anton-trunov self-assigned this Feb 26, 2025
@novusnota
Copy link
Member

Fixed snapshots (hopefully)

Copy link
Member

@novusnota novusnota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AWESOME STUFF @jeshecdom @anton-trunov

Triple :shipit: :shipit: :shipit:

@anton-trunov anton-trunov merged commit 444ea02 into main Feb 26, 2025
22 of 24 checks passed
@anton-trunov anton-trunov deleted the jeshecdom/empty-string-receiver branch February 26, 2025 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment