Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(protocol): check ontake for height in _proposeBlock #18329

Merged
merged 5 commits into from
Oct 28, 2024
Merged

fix(protocol): check ontake for height in _proposeBlock #18329

merged 5 commits into from
Oct 28, 2024

Conversation

dantaik
Copy link
Contributor

@dantaik dantaik commented Oct 28, 2024

No description provided.

@dantaik dantaik changed the base branch from main to ontake_cleanup2 October 28, 2024 10:05
@dantaik dantaik marked this pull request as ready for review October 28, 2024 10:05
@dantaik dantaik enabled auto-merge October 28, 2024 10:05
@dantaik dantaik disabled auto-merge October 28, 2024 10:08
@dantaik dantaik enabled auto-merge October 28, 2024 10:09
@openzeppelin-code OpenZeppelin Code
Copy link

openzeppelin-code bot commented Oct 28, 2024 •
edited
Loading

fix(protocol): check ontake for height in _proposeBlock

Generated at commit: e165a9d7c27911d49468a234052b9aff69a175d8

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total		 3
3
0
7
42
55
Dependencies Critical
High
Medium
Low
Note
Total		 0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

@dantaik dantaik added this pull request to the merge queue Oct 28, 2024
Merged via the queue into ontake_cleanup2 with commit eb47f88 Oct 28, 2024
5 checks passed
@dantaik dantaik deleted the extra_check_getBlock branch October 28, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YoGhurt111 YoGhurt111 YoGhurt111 approved these changes

@davidtaikocha davidtaikocha davidtaikocha approved these changes

@smtmfft smtmfft Awaiting requested review from smtmfft

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dantaik @YoGhurt111 @davidtaikocha