add mac friendly options in script (fix bashisms, file paths, need OSx tester) #11

tallguyjenks · 2020-04-21T22:29:32Z

No description provided.

tallguyjenks · 2020-04-24T19:20:25Z

@jhonkaman someone on reddit who was messing with the script got an answer for me... maybe.. what do you see in you ~/Library/Application Support directory? are there data files in there used by programs?

grokskookum · 2020-04-24T19:24:35Z

Mac puts files here (example firefox)

myself:~ dznutz$ sudo find ~/Library/ -type f |grep -i firefox | cut -f 1-8 -d / | uniq -c |sort -n
1 /Users/dznutz/Library//Application Support/Firefox/installs.ini
1 /Users/dznutz/Library//Application Support/Firefox/profiles.ini
1 /Users/dznutz/Library//Application Support/WebEx Folder/Add-ons
1 /Users/dznutz/Library//Caches/org.mozilla.firefox/Cache.db
1 /Users/dznutz/Library//Caches/org.mozilla.firefox/Cache.db-shm
1 /Users/dznutz/Library//Caches/org.mozilla.firefox/Cache.db-wal
1 /Users/dznutz/Library//Caches/org.mozilla.firefox/WebKitCache
1 /Users/dznutz/Library//Preferences/org.mozilla.firefox.plist
1 /Users/dznutz/Library//Saved Application State/org.mozilla.firefox.savedState/data.data
1 /Users/dznutz/Library//Saved Application State/org.mozilla.firefox.savedState/window_1.data
1 /Users/dznutz/Library//Saved Application State/org.mozilla.firefox.savedState/windows.plist
3 /Users/dznutz/Library//Caches/Mozilla/updates
14 /Users/dznutz/Library//Application Support/Firefox/Crash Reports
529 /Users/dznutz/Library//Caches/Firefox/Profiles
2064 /Users/dznutz/Library//Application Support/Firefox/Profiles

tallguyjenks · 2020-04-24T19:34:20Z

lol @grokskookum, i dig the username haha. it looks like Library may be the place, your links have 2 slashes between library and things lke Application support, is there a missing field in there?

jhonkaman · 2020-04-24T19:47:30Z

@tallguyjenks there are a lot of folders in ~/Library/Application Support. It looks like there is 1 folder for each application I have installed. If I look inside the folders, I see different types of files, but I do see a lot of .plist files, which I think fall under the category of data files that you're referring to.

tallguyjenks · 2020-04-24T19:52:33Z

@jhonkaman the single folder per application was probably what i was looking for. in that case, can you install the dependencies listed in the readme fzf and bat? and if so do they run as expected in your cli?

jhonkaman · 2020-04-24T20:10:35Z

Yes, I'll try installing them now.

jhonkaman · 2020-04-24T20:36:19Z

It looks like fzf and bat are working as expected, but I'm not sure how to get them to work together at the moment.

tallguyjenks · 2020-04-24T21:29:01Z

no need, the script should take care of that, but i need to adjust for mac, ill do that tonight, finishing my work day and errands at the moment

tallguyjenks · 2020-04-25T02:20:27Z

@jhonkaman or @grokskookum what is the output of the uname command in your terminal, and also the uname -s command

jhonkaman · 2020-04-25T18:59:13Z

The output for both of those commands is Darwin for me.

tallguyjenks · 2020-04-25T21:59:38Z

excellent, then i may have a fix with a simple case statement. then ill need to you add the new script to a place in your $PATH then run it and see if anything breaks, will update you at that point

tallguyjenks · 2020-04-26T02:35:00Z

@jhonkaman can you run this command in your terminal echo "$HOME" and tell me the output, and what terminal emulator are you running? and also how did you install fzf and bat onto your machine?

tallguyjenks · 2020-04-27T02:31:55Z

@jhonkaman @grokskookum ive pushed a mac friendly version to master, please test and see if it works as expected. put the flash script in your $PATH somewhere and run it :)

jhonkaman · 2020-04-27T05:27:36Z

For your previous question, echo $HOME outputs /Users/Javier.

The terminal emulator is just the built-in Terminal app on macOS.

I installed fzf and bat using Homebrew. I'll try installing your script tomorrow.

tallguyjenks · 2020-04-27T05:31:50Z

perfect, if it works, then with homebrew installation of the 2 programs, we'll be good to go on mac!

jhonkaman · 2020-04-27T19:46:21Z

I got the following output when I ran flash:

/usr/local/bin/flash: line 108: [: /Users/Javier/Library/Application: binary operator expected
/usr/local/bin/flash: line 119: cd: /Users/Javier/Library/Application Support/flash: No such file or directory
find: illegal option -- m
usage: find [-H | -L | -P] [-EXdsx] [-f path] path ... [expression]
       find [-H | -L | -P] [-EXdsx] -f path [path ...] [expression]
touch: /Users/Javier/Library/Application Support/flash/.highscore: No such file or directory
touch: /Users/Javier/Library/Application Support/flash/.reviews: No such file or directory
find: illegal option -- m
usage: find [-H | -L | -P] [-EXdsx] [-f path] path ... [expression]
       find [-H | -L | -P] [-EXdsx] -f path [path ...] [expression]

Maybe I messed up the installation.

tallguyjenks · 2020-04-27T19:57:07Z

@jhonkaman no i see what went wrong, the mac file path has a space in it and i didnt quote one of the instances of the variable holding the file path, i just fixed, grab the latest commit of the script and try again

jhonkaman · 2020-04-27T20:20:56Z

Got a little farther:

No .local/share/flash directory, make it? Y/N
y
touch: Support/flash/deck.csv: No such file or directory
touch: Support/flash/.highscore: No such file or directory
touch: Support/flash/.reviews: No such file or directory
find: illegal option -- m
usage: find [-H | -L | -P] [-EXdsx] [-f path] path ... [expression]
       find [-H | -L | -P] [-EXdsx] -f path [path ...] [expression]
find: illegal option -- m
usage: find [-H | -L | -P] [-EXdsx] [-f path] path ... [expression]
       find [-H | -L | -P] [-EXdsx] -f path [path ...] [expression]

tallguyjenks · 2020-04-27T20:28:04Z

@jhonkaman found'em, more unquoted paths, thanks apple... lol rinse and repeat, try again with latest build

jhonkaman · 2020-04-27T20:48:01Z

Ok. Still getting these errors:

find: illegal option -- m
usage: find [-H | -L | -P] [-EXdsx] [-f path] path ... [expression]
       find [-H | -L | -P] [-EXdsx] -f path [path ...] [expression]
find: illegal option -- m
usage: find [-H | -L | -P] [-EXdsx] [-f path] path ... [expression]
       find [-H | -L | -P] [-EXdsx] -f path [path ...] [expression]

tallguyjenks · 2020-04-27T20:56:40Z

okay try again, i switched some of the command substitution quoting

and can you post the output of man find for me?

jhonkaman · 2020-04-27T21:13:29Z

I think this page has the info you need for man find: https://www.freebsd.org/cgi/man.cgi?query=find&apropos=0&sektion=0&manpath=FreeBSD+12.1-RELEASE+and+Ports&arch=default&format=html

tallguyjenks · 2020-04-27T21:17:55Z

well for the Darwin page, it says the -maxdepth option the way im using it is valid, i quoted the variable feeding it, so try again and see if the latest push works

jhonkaman · 2020-04-27T21:40:37Z

Ok I think that worked. This is what I see now. How do I get the sample deck?

No decks were found, please make a new deck
using : as a delimiter in a .csv file in
the .local/share/flash directory.

An example of a card:
Math:What is the square root of 4?:2:0

tallguyjenks · 2020-04-27T22:08:04Z

thats good, but not the answer that should have been displayed, can you ls -la the contents of the ~/Application Support/flash directory?

i pushed some more changes to try after that too

jhonkaman · 2020-04-27T23:39:11Z

ls -la for ~/Library/Application Support/flash (I had to add in the Library part to get the right path):

total 0
drwxr-xr-x   4 Javier  staff   128B Apr 27 13:19 ./
drwx------+ 88 Javier  staff   2.8K Apr 27 13:19 ../
-rw-r--r--   1 Javier  staff     0B Apr 27 13:19 .highscore
-rw-r--r--   1 Javier  staff     0B Apr 27 13:19 .reviews

tallguyjenks · 2020-04-28T01:11:42Z

okay so its not making the example deck like it should, did you re-run the latest commit: 46deb03

jhonkaman · 2020-04-28T22:02:11Z

Yes, I'm still getting the same output from above.

tallguyjenks · 2020-04-28T22:25:01Z

i think it may have been the use of variables in the brace expansion for OSx... maybe. moved some things around try latest build

jhonkaman · 2020-04-28T23:42:16Z

I tried the latest build, but I'm still getting the same output.

tallguyjenks · 2020-04-28T23:43:35Z

okay i have 2 more ideas for this issue. can you first test and anywhere in your system run touch test.csv and see if it is in fact creating the file

jhonkaman · 2020-04-29T05:30:23Z

touch test.csv does create a file.

tallguyjenks · 2020-04-29T05:42:52Z

@jhonkaman alright i removed the brace expansion and just made individual touch commands, try build c8391d9

jhonkaman · 2020-04-29T22:12:44Z

Now I'm getting the previous error again:

find: illegal option -- m
usage: find [-H | -L | -P] [-EXdsx] [-f path] path ... [expression]
       find [-H | -L | -P] [-EXdsx] -f path [path ...] [expression]

No decks were found, please make a new deck
using : as a delimiter in a .csv file in
the /Users/Javier/Library/Application Support/flash directory.

An example of a card:
Math:What is the square root of 4?:2:0

tallguyjenks · 2020-04-29T22:28:03Z

god, mac is such a pain. try 9ab26d5

jhonkaman · 2020-05-01T20:42:19Z

I'm still getting the same output. I think this might be the issue: https://stackoverflow.com/questions/17548854/difference-between-mac-find-and-linux-find

tallguyjenks · 2020-05-01T20:57:56Z

@jhonkaman alright, i added the find path, lets see if the latest build works 0b1f60a

jhonkaman · 2020-05-01T21:16:46Z

Ok, that got rid of the error. Still getting this part:

No decks were found, please make a new deck
using : as a delimiter in a .csv file in
the /Users/Javier/Library/Application Support/flash directory.

An example of a card:
Math:What is the square root of 4?:2:0

If I had to guess, it looks like you're checking to see if any decks exist on line 124 and returning to the starting directory if there aren't any decks. I think you should add the touch command there from your setup() function to create the example deck.

tallguyjenks · 2020-05-01T21:20:25Z

first, can you remove the entire directory and all its contents and run it fresh? the script is meant to work on the first go, if it makes the directory but not the deck then it will be stuck until a deck is made, try a clean slate one more time

tallguyjenks · 2020-05-01T21:22:13Z

with build
5c717b1

jhonkaman · 2020-05-02T01:49:24Z

Ok, tried it. Output:

No /Users/Javier/Library/Application Support/flash directory, make it? Y/N
y
touch: Support/flash/deck.csv: No such file or directory
touch: Support/flash/.highscore: No such file or directory
touch: Support/flash/.reviews: No such file or directory

No decks were found, please make a new deck
using : as a delimiter in a .csv file in
the /Users/Javier/Library/Application Support/flash directory.

An example of a card:
Math:What is the square root of 4?:2:0

tallguyjenks · 2020-05-02T02:13:40Z

Progress! i get it now, i think i need to escape the spaces in the double quoted strings, new build coming in one sec.... okay: 23baa6d

jhonkaman · 2020-05-02T20:18:25Z

Ok, now I'm getting two things:

No /Users/Javier/Library/Application\ Support/flash directory, make it? Y/N
y
mkdir: /Users/Javier/Library/Application\ Support: No such file or directory
/usr/local/bin/flash: line 121: cd: /Users/Javier/Library/Application\ Support/flash: No such file or directory
touch: /Users/Javier/Library/Application\ Support/flash/.highscore: No such file or directory
touch: /Users/Javier/Library/Application\ Support/flash/.reviews: No such file or directory
/usr/local/bin/flash: line 147: shuf: command not found

And:

\e[1mCards Reviewed:\e[1m	0
cat: /Users/Javier/Library/Application\ Support/flash/.highscore: No such file or directory
    \e[1mHigh Score:\e[1m	
awk: can't open file /Users/Javier/Library/Application\ Support/flash/.reviews
 source line number 1
    \e[1mAvg review:\e[1m	

Category:
        
Question:

Also it says .//test.csv on the actual flashcard screen:

jhonkaman · 2020-05-07T19:52:31Z

I installed coreutils and tried the latest version, but got this error:

No HOME/Library/Application Support/flash directory, make it? Y/N
y
mkdir: HOME/Library/Application Support: No such file or directory
/usr/local/bin/flash: line 133: cd: HOME/Library/Application Support/flash: No such file or directory

tallguyjenks · 2020-05-07T21:01:14Z

@jhonkaman found it, it was a missing $ for the mac file path $HOME variable. and fixed another issue with the installation of coreutils shuf is installed as gshuf so i alias it in the script to retain functionality. test latest build

jhonkaman · 2020-05-12T20:51:47Z

Latest output:

No /Users/Javier/Library/Application Support/flash directory, make it? Y/N
y
touch: Support/flash/deck.csv: No such file or directory
touch: Support/flash/.highscore: No such file or directory
touch: Support/flash/.reviews: No such file or directory

jhonkaman · 2020-05-12T20:53:20Z

Also, does it matter if my shell is zsh?

tallguyjenks · 2020-05-12T23:20:13Z

yeah it matters, zsh breaks scripts with bashisms im not sure if thats whats happening or not though..

jsnal · 2020-05-14T02:46:02Z

It shouldn't matter if your shell is zsh. Your script includes a shebang line at the top, so as long as you're invoking the file using source or ./ it will use the interpreter in the shebang line. In this case, it's in your path so it's essentially sourcing it.

Seems like the way deck.csv (and the other two) is being appended to $DIR could be the problem. However, it seems right to me. Maybe it works differently when concatenating strings with spaces?

tallguyjenks · 2020-05-14T05:39:27Z

@jsnal thats what im thinking and im unsure about how to make it work at this point, i tried to escape the space but IIRC that breaks the file path

jsnal · 2020-05-14T17:32:03Z

Alright so I did some testing and it seems like if you remove eval from your touch statement it works as expected. I tested it with Linux and macOS 10.14.6 (Mojave) and it seems to install everything fine. Why are you using eval there?

tallguyjenks · 2020-05-14T18:06:05Z

originally it was helping with another issue or so i thought, but if removing it makes it function as expected, wanna send a pull request? :) and thanks for testing! this is great if it now works on macOS!

…

On 20/05/14 10:32AM, Jason wrote: Alright so I did some testing and it seems like if you remove eval from your touch statement it works as expected. I tested it with Linux and macOS 10.14.6 (Mojave) and it seems to install everything fine. Why are you using eval there? — You are receiving this because you were mentioned. Reply to this email directly, [1]view it on GitHub, or [2]unsubscribe. References 1. #11 (comment) 2. https://github.com/notifications/unsubscribe-auth/AHD5FNS67KY2JEX3UZELSYLRRQTKFANCNFSM4MNVHDMQ

tallguyjenks added enhancement New feature or request help wanted Extra attention is needed labels Apr 21, 2020

jsnal mentioned this issue May 14, 2020

Fix macOS installation function #26

Merged

tallguyjenks closed this as completed in #26 May 14, 2020

tallguyjenks added a commit that referenced this issue May 14, 2020

update README after #11 resolution

73e4ea3

add mac friendly options in script (fix bashisms, file paths, need OSx tester) #11

add mac friendly options in script (fix bashisms, file paths, need OSx tester) #11

Comments

tallguyjenks commented Apr 21, 2020

tallguyjenks commented Apr 24, 2020

grokskookum commented Apr 24, 2020

tallguyjenks commented Apr 24, 2020

jhonkaman commented Apr 24, 2020

tallguyjenks commented Apr 24, 2020

jhonkaman commented Apr 24, 2020

jhonkaman commented Apr 24, 2020

tallguyjenks commented Apr 24, 2020

tallguyjenks commented Apr 25, 2020

jhonkaman commented Apr 25, 2020

tallguyjenks commented Apr 25, 2020

tallguyjenks commented Apr 26, 2020 • edited Loading

tallguyjenks commented Apr 27, 2020

jhonkaman commented Apr 27, 2020

tallguyjenks commented Apr 27, 2020

jhonkaman commented Apr 27, 2020

tallguyjenks commented Apr 27, 2020

jhonkaman commented Apr 27, 2020

tallguyjenks commented Apr 27, 2020

jhonkaman commented Apr 27, 2020

tallguyjenks commented Apr 27, 2020

jhonkaman commented Apr 27, 2020

tallguyjenks commented Apr 27, 2020

jhonkaman commented Apr 27, 2020

tallguyjenks commented Apr 27, 2020

jhonkaman commented Apr 27, 2020 • edited Loading

tallguyjenks commented Apr 28, 2020

jhonkaman commented Apr 28, 2020

tallguyjenks commented Apr 28, 2020

jhonkaman commented Apr 28, 2020

tallguyjenks commented Apr 28, 2020

jhonkaman commented Apr 29, 2020

tallguyjenks commented Apr 29, 2020 • edited Loading

jhonkaman commented Apr 29, 2020

tallguyjenks commented Apr 29, 2020

jhonkaman commented May 1, 2020

tallguyjenks commented May 1, 2020

jhonkaman commented May 1, 2020

tallguyjenks commented May 1, 2020

tallguyjenks commented May 1, 2020

jhonkaman commented May 2, 2020

tallguyjenks commented May 2, 2020

jhonkaman commented May 2, 2020

jhonkaman commented May 7, 2020

tallguyjenks commented May 7, 2020

jhonkaman commented May 12, 2020

jhonkaman commented May 12, 2020

tallguyjenks commented May 12, 2020

jsnal commented May 14, 2020

tallguyjenks commented May 14, 2020

jsnal commented May 14, 2020

tallguyjenks commented May 14, 2020 via email

tallguyjenks commented Apr 26, 2020 •

edited

Loading

jhonkaman commented Apr 27, 2020 •

edited

Loading

tallguyjenks commented Apr 29, 2020 •

edited

Loading