Feature/xrp pkg #329
Merged
Feature/xrp pkg #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportCI ran the following commands for commit e928404. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 3 targetsSent with 💌 from NxCloud. |
npwork
reviewed
Jan 26, 2022
packages/blockchain/xrp/project.json
Outdated
| "tsConfig": "packages/blockchain/xrp/tsconfig.lib.json", | ||
| "packageJson": "packages/blockchain/xrp/package.json", | ||
| "main": "packages/blockchain/xrp/src/index.ts", | ||
| "assets": ["packages/blockchain/xrp/*.md"] |
| */ | ||
| async sign(tx: ChainTransactionKMS, secret: string) { | ||
| ;(tx as PendingTransaction).chain = 'XRP' as any | ||
| const rippleAPI = new RippleAPI() |
There was a problem hiding this comment.
do we need to create RippleAPI every single time or we can move it line 7?
| * @param body content of the transaction to broadcast | ||
| * @returns transaction id of the transaction in the blockchain | ||
| */ | ||
| export const sendTransaction = async (body: TransferXrpBlockchain) => { |
There was a problem hiding this comment.
why do we need to export this function?
| * @param body content of the transaction to broadcast | ||
| * @returns transaction data to be broadcast to blockchain. | ||
| */ | ||
| export const prepareSignedTransaction = async (body: TransferXrpBlockchain) => { |
There was a problem hiding this comment.
why do we need to export this function?
| const { address, secret } = await sdk.wallet() | ||
| expect(address).toMatch(testData.ADDRESS_REGEX) | ||
| expect(secret).toMatch(testData.SECRET_REGEX) | ||
| } catch (e) { |
There was a problem hiding this comment.
you don't need this try catch
npwork
approved these changes
Jan 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.