Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporal: Test coverage for rejecting too large dates in PlainMonthDay strings #4389

Merged
merged 1 commit into from
Feb 22, 2025

Conversation

ptomato
Copy link
Contributor

@ptomato ptomato commented Feb 5, 2025

This adds coverage for the normative change in tc39/proposal-temporal#3054, which specifies that implementations must throw on out-of-range dates in RFC 9557 strings for non-ISO calendars.

@ptomato ptomato requested a review from a team as a code owner February 5, 2025 18:12
@ptomato ptomato marked this pull request as draft February 5, 2025 18:12
@ptomato ptomato added needs review awaiting consensus This needs committee consensus before it can be eligible to be merged. labels Feb 5, 2025
@ptomato
Copy link
Contributor Author

ptomato commented Feb 5, 2025

Draft until the normative change is approved in TC39.

@ptomato ptomato marked this pull request as ready for review February 20, 2025 21:04
@ptomato ptomato removed the awaiting consensus This needs committee consensus before it can be eligible to be merged. label Feb 20, 2025
@ptomato
Copy link
Contributor Author

ptomato commented Feb 20, 2025

The corresponding normative change which this PR tests was approved on 2025-02-18 in the TC39 plenary.

…y strings

This adds coverage for the normative change in
tc39/proposal-temporal#3054, which specifies that
implementations must throw on out-of-range dates in RFC 9557 strings for
non-ISO calendars.
@ptomato ptomato merged commit 44d71fb into tc39:main Feb 22, 2025
11 checks passed
@ptomato ptomato deleted the temporal-3054 branch February 22, 2025 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants