Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/svelte v5 #176

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Feat/svelte v5 #176

wants to merge 3 commits into from

Conversation

escapedcat
Copy link
Contributor

  1. used migration script to update to v5
  2. fixed a enum usage which is not supported in v5 anymore
  3. updated further svelte deps which also adjusted for v5
  4. still issues left

known issues so far

4:49:30 PM [vite] (ssr) Error when evaluating SSR module /src/routes/+page.svelte: Your application, or one of its dependencies, imported from 'svelte/internal', which was a private module used by Svelte 4 components that no longer exists in Svelte 5. It is not intended to be public API. If you're a library author and you used 'svelte/internal' deliberately, please raise an issue on https://github.com/sveltejs/svelte/issues detailing your use case.
      at /Users/user/data/src/btc/btcmap.org/node_modules/svelte/src/internal/index.js:3:7
      at ESModulesEvaluator.runInlinedModule (file:///Users/user/data/src/btc/btcmap.org/node_modules/vite/dist/node/module-runner.js:1057:6)
      at SSRCompatModuleRunner.directRequest (file:///Users/user/data/src/btc/btcmap.org/node_modules/vite/dist/node/module-runner.js:1271:82)
      at SSRCompatModuleRunner.directRequest (file:///Users/user/data/src/btc/btcmap.org/node_modules/vite/dist/node/chunks/dep-Cg8OuIew.js:31756:35)
      at SSRCompatModuleRunner.cachedRequest (file:///Users/user/data/src/btc/btcmap.org/node_modules/vite/dist/node/module-runner.js:1166:28)
      at request (file:///Users/user/data/src/btc/btcmap.org/node_modules/vite/dist/node/module-runner.js:1215:79)
      at async eval (/Users/user/data/src/btc/btcmap.org/node_modules/@tanstack/svelte-table/build/lib/index.mjs:3:159)

Copy link

netlify bot commented Feb 21, 2025

Deploy Preview for btcmap failed.

Name Link
🔨 Latest commit ed5cb75
🔍 Latest deploy log https://app.netlify.com/sites/btcmap/deploys/67b8a16f6e93fd0008d4630f

@dadofsambonzuki
Copy link
Member

dadofsambonzuki commented Feb 21, 2025

I heard v5 is quite a departure and has issues.

https://njump.me/naddr1qqxnzden8yurxvp4xcerzdfeqgsf03c2gsmx5ef4c9zmxvlew04gdh7u94afnknp33qvv3c94kvwxgsrqsqqqa28ae4fzd

Thoughts?

@escapedcat
Copy link
Contributor Author

Interesting post! Thanks!

I really do not know a lot about svelte. Just wanted to give this a try. And it's not yet working.
If this ever works this we can have a look how it feels and if this runs into similar issues as mentioned in the post.
I'm also fine with sticking to v4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants