Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vector tile support #179

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add vector tile support #179

wants to merge 4 commits into from

Conversation

bubelov
Copy link
Collaborator

@bubelov bubelov commented Feb 24, 2025

Experimental branch, needs review and feedback

Known issues: https://github.com/maplibre/maplibre-gl-leaflet/issues

Copy link

socket-security bot commented Feb 24, 2025

New and updated dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@mapbox/[email protected] None 0 67.8 kB mapbox-npm
npm/@mapbox/[email protected] None 0 23.8 kB flippmoke
npm/@mapbox/[email protected] None 0 10.7 kB mapbox-npm-09
npm/@mapbox/[email protected] None 0 5.01 kB mapbox-npm
npm/@mapbox/[email protected] None 0 262 kB anandthakker
npm/@mapbox/[email protected] None 0 10.5 kB mapbox-npm-03
npm/@maplibre/[email protected] None 0 30.6 kB maplibreorg
npm/@maplibre/[email protected] None 0 9.12 MB maplibreorg
npm/@types/[email protected] None 0 6.96 kB types
npm/@types/[email protected] 🔁 npm/@types/[email protected] None 0 9.51 kB types
npm/@types/[email protected] None 0 5.38 kB types
npm/@types/[email protected] None 0 5.04 kB types
npm/@types/[email protected] None 0 4.64 kB types
npm/@types/[email protected] None 0 8.4 kB types
npm/[email protected] None 0 95.2 kB mourner
npm/[email protected] None 0 71.1 kB mourner
npm/[email protected] None 0 770 kB toji
npm/[email protected] environment, filesystem 0 8.27 kB jonschlinkert
npm/[email protected] None 0 6.8 kB feross
npm/[email protected] None 0 9.3 kB isaacs
npm/[email protected] None 0 7.41 kB lydell
npm/[email protected] None 0 34.4 kB mourner
npm/[email protected] None 0 22.8 kB doowb
npm/[email protected] network 0 33.6 MB maplibreorg
npm/[email protected] None 0 6.34 kB mikolalysenko
npm/[email protected] None 0 126 kB mapbox-npm-05
npm/[email protected] None 0 7.11 kB mourner
npm/[email protected] None 0 68.7 kB mafintosh
npm/[email protected] None 0 5.98 kB mourner
npm/[email protected] filesystem 0 5.24 kB mafintosh
npm/[email protected] filesystem 0 24.2 kB mbostock
npm/[email protected] None 0 57.7 kB mourner
npm/[email protected] None 0 8.74 kB mourner
npm/[email protected] None 0 12 kB mourner
npm/[email protected] environment 0 9.42 kB isaacs

View full report↗︎

Copy link

netlify bot commented Feb 24, 2025

Deploy Preview for btcmap ready!

Name Link
🔨 Latest commit 495f251
🔍 Latest deploy log https://app.netlify.com/sites/btcmap/deploys/67bd650359ecea0008d2ec4f
😎 Deploy Preview https://deploy-preview-179--btcmap.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 52 (🟢 up 15 from production)
Accessibility: 84 (no change from production)
Best Practices: 83 (🔴 down 9 from production)
SEO: 100 (no change from production)
PWA: 90 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@dadofsambonzuki
Copy link
Member

dadofsambonzuki commented Feb 24, 2025

Have tested in a variety or browsers and devices and looks good. Better UX and I actually prefer the new dark tiles.

We need to:

  • sync the initial tile selection to the Dark/Light mode setting on the Web App. It currently defaults to a light map when in dark mode.
  • Remove StadiaMaps Copyright

@escapedcat
Copy link
Contributor

Tested on chrome canary. Feels great! Code lgtm

@bubelov
Copy link
Collaborator Author

bubelov commented Feb 25, 2025

@dadofsambonzuki it defaults to raster tiles, since vector layers are untested. There are some annoying issues with Leaflet vector plugin, like maxZoom being ignored and map starts to jitter once you zoom in too much. I have no idea if it can be fixed but we can probably live with that.

@escapedcat if everyone is okay with that, I'll merge it with the following changes:

  1. Vector layers will be default, with an optional fallback to OSM raster. We can use dark vector style for a dark mode and light style for the light mode.
  2. Removing Stadia copyright

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants