-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PipelineResource for S3 buckets (for IBM COS, AWS S3, Minio ...) #323
Comments
I would like to contribute on this issue since we are on AWS+EKS. Considering https://github.com/knative/build-pipeline/blob/master/pkg/apis/pipeline/v1alpha1/gcs_resource.go it seems straight forward but any pointers would be nice, following Finding something to work on on CONTRIBUTING.md |
Sounds good @mustafaakin ! I'm excited that you want to contribute :D! (btw if you haven't already plz feel free to join us in slack at #build-pipeline !) |
I think to properly support this we should expand our end to end tests to support using S3 as well (not to mention other clouds in general!), but I think there's probably a bit of work to do there so for now I think we should add this functionality, initially not cover it with end to end tests, and create a separate issue around setting up infrastructure for end to end tests against s3. (Any other thoughts @shashwathi @pivotal-nader-ziada @imjasonh @tejal29 ?) |
Or maybe a better idea: add an end to end test that is skipped by default, which folks can run manually? |
btw this go library is a great way to work with all the different cloud blob storage provides (GCS, S3, Azure etc) https://github.com/google/go-cloud via https://github.com/google/go-cloud/tree/master/blob using a simple URL scheme |
Sorry for the late reply, assuming we use go-cloud, what would be the way to go? Right now there is GCS Storage resource and it would be a duplicate. |
What do you think about keeping a single |
That does sound like a good diea @dlorenc - and maybe in that case it would make sense to try out |
As chance would have it, I had made a step and a small task/utility using |
…ease-version Reflect Tekton release version in Artifacts after release
Stale issues rot after 30d of inactivity. /lifecycle rotten Send feedback to tektoncd/plumbing. |
Two possible ways to handle this:
There is also the PipelineResource redesign in #1673 Given all of that it feels reasonable to me to close this for now. |
Expected Behavior
Ability to use S3 for object storage as PipelineResources types
Actual Behavior
#321 exists for GCS but does not support S3
Additional Info
In multi-zone clusters, PVCs can be difficult and sometimes its prefered to transfer artifacts between tasks in a pipeline using other types of storage.
The text was updated successfully, but these errors were encountered: