-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typo in entrypoint folder #3153
Conversation
Hi @ywluogg. Thanks for your PR. I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hey Yawen, thanks for the fix! The change looks good, there's just a couple things we need to do before we can merge this:
Let me know if you have any trouble and I can try to help in either case. |
/ok-to-test |
Oh we'll also want a more descriptive PR title than "Typo" -- your change description in the PR body ("Fix typo in entrypoint folder") would make a good PR title. (This is actually also related to commit squashing -- when a PR includes multiple changes GitHub chooses the branch name for the PR title, which tends to be pretty non-descriptive. When there's only one squashed change, GitHub chooses that commit description for the PR title, which is usually much better) |
Thanks for the comment. Edited the commit based on them |
/kind documentation |
/lgtm |
/lgtm Edit: I thought this was the catalog repo. 😝 🤦 |
/lgtm Looking Good! 🤙🏽 |
/test check-pr-has-kind-label |
I still have check-pr-has-kind-label marked as yellow but it already has a kind tag. |
My checks were stuck, so I tried pushing a empty commit to re-try the checks to see if it fixes it. |
/lgtm |
/assign @imjasonh |
/approve 🎉 |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ImJasonH The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
Fix typo in entrypoint folder
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmd
dir, please updatethe release Task to build and release this image.
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.
Release Notes