Enable Bundles and Custom Tasks when feature gate is set to "alpha" #3908

ghost · 2021-04-29T20:03:16Z

Changes

Prior to this commit the Tekton Bundles and Custom Task features were only enabled
when their individual flags were set to "true" in the feature-flags configmap.

After this commit the two features are also enabled when enable-api-fields is "alpha".

Note that it is not possible to set the "alpha" feature gate but disable Bundles / Custom Tasks. These features are "alpha features" so they're always enabled regardless of their own feature flags if the gate is set to "alpha".

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

Docs included if any changes are user facing
Tests included if any functionality added or changed
Follows the commit message standard
Meets the Tekton contributor standards (including
functionality, content, code)
Release notes block below has been filled in or deleted (only if no user facing changes)

Release Notes

Switching the "enable-api-fields" feature gate to "alpha" also turns on Tekton Bundles and Custom Tasks support, since these are alpha features.

tekton-robot · 2021-04-29T20:05:31Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/config/feature_flags.go	82.5%	83.7%	1.2

tekton-robot · 2021-04-29T20:08:53Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/config/feature_flags.go	82.5%	83.7%	1.2

tekton-robot · 2021-04-29T20:12:18Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/config/feature_flags.go	82.5%	83.7%	1.2

tekton-robot · 2021-04-29T20:22:32Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/config/feature_flags.go	82.5%	83.7%	1.2

afrittoli

Thank you for this - it looks really nice!
Just a couple of minor comments :)
/approve

afrittoli · 2021-04-30T08:43:19Z

docs/install.md

+Features currently in "alpha" are:
+
+- [Tekton Bundles](./taskruns.md#tekton-bundles)
+- Custom Tasks


Maybe add a link to ./runs.md ? Or https://github.com/tektoncd/community/blob/main/teps/0002-custom-tasks.md?

Ahhhh this is exactly what I needed, thanks!

pkg/apis/config/feature_flags_test.go

afrittoli · 2021-04-30T09:10:51Z

test/gate.go

+// test if none of the feature-flags in the given map match
+// what's in the feature-flags ConfigMap. It will fatally fail
+// the test if it cannot get the feature-flag configmap.
+func requireAnyGate(gates map[string]string) func(context.Context, *testing.T, *clients, string) {


vdemeester

/meow

tekton-robot · 2021-04-30T10:53:48Z

@vdemeester:

In response to this:

/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tekton-robot · 2021-04-30T10:53:52Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afrittoli, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [afrittoli,vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ghost · 2021-04-30T11:51:59Z

Thanks for the reviews! Updated with a test for "stable" gate + bundles:"true" + custom-tasks: "true" & links from the install doc to runs.md.

Edit: stealthy ninja pushed an update to developer docs too so that requireAnyGate is documented.

tekton-robot · 2021-04-30T11:52:52Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/config/feature_flags.go	82.5%	83.7%	1.2

ghost · 2021-04-30T12:04:03Z

Also just manually verified that custom tasks tests do indeed run when either the gate is "alpha" or the feature's flag is "true". Here's what a skip looks like:

=== RUN   TestCustomTask
    init_test.go:132: Create namespace arendelle-5d8z7 to deploy to
    init_test.go:148: Verify SA "default" is created in namespace "arendelle-5d8z7"
    gate.go:32: No feature flag matching "enable-custom-tasks": "true" or "enable-api-fields": "alpha"
--- SKIP: TestCustomTask (1.04s)

tekton-robot · 2021-04-30T12:08:16Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/config/feature_flags.go	82.5%	83.7%	1.2

afrittoli

Thank you!
/lgtm

afrittoli · 2021-04-30T14:29:04Z

/test pull-tekton-pipeline-integration-tests

ghost · 2021-04-30T14:53:07Z

/test pull-tekton-pipeline-integration-tests

…pha" Prior to this commit the Tekton Bundles and Custom Task features were only enabled when their individual flags were set to "true" in the feature-flags configmap. After this commit the two features are enabled if enable-api-fields is "alpha" or if their individual flags are set to "true". Note that it is _not_ possible to set the "alpha" feature gate but disable Bundles / Custom Tasks. These features are "alpha features" so they're always enabled regardless of their own feature flags if the gate is set to "alpha".

tekton-robot · 2021-04-30T18:44:43Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/config/feature_flags.go	82.5%	83.7%	1.2

ghost · 2021-04-30T19:07:22Z

The workspace-in-sidecar example was failing over and over again. Adding explicit resources.requests to the example seems to have fixed that 🤞 : https://github.com/tektoncd/pipeline/pull/3908/files#diff-d3a6963f568541460e24acddf2bcc5d3337bbbc8632e91a63ee59c6084891a2e

This is ready for a final lgtm (hopefully!)

pritidesai · 2021-05-03T18:44:53Z

I tried running custom task which failed with an error:

{"level":"error","ts":"2021-05-03T18:37:17.747Z","logger":"tekton-pipelines-controller","caller":"pipelinerun/pipelinerun.go:244","msg":"Reconcile error: Couldn't retrieve Task \"testloop\": tasks.tekton.dev \"testloop\" not found","commit":"13a40db","knative.dev/controller":"garden.eu.org.tektoncd.pipeline.pkg.reconciler.pipelinerun.Reconciler","knative.dev/kind":"tekton.dev.PipelineRun","knative.dev/traceid":"13fb3555-5186-4077-be81-573413801e63","knative.dev/key":"default/testpipeline-run-854c7","stacktrace":"github.com/tektoncd/pipeline/pkg/reconciler/pipelinerun.(*Reconciler).ReconcileKind\n\tgithub.com/tektoncd/pipeline/pkg/reconciler/pipelinerun/pipelinerun.go:244\ngithub.com/tektoncd/pipeline/pkg/client/injection/reconciler/pipeline/v1beta1/pipelinerun.(*reconcilerImpl).Reconcile\n\tgithub.com/tektoncd/pipeline/pkg/client/injection/reconciler/pipeline/v1beta1/pipelinerun/reconciler.go:240\nknative.dev/pkg/controller.(*Impl).processNextWorkItem\n\tknative.dev/[email protected]/controller/controller.go:530\nknative.dev/pkg/controller.(*Impl).RunContext.func3\n\tknative.dev/[email protected]/controller/controller.go:468"}

But testloop is not a resource of type tasks.tekton.dev:

tkn pipelinerun logs testpipeline-run-854c7 -f -n default
Pipeline default/testpipeline can't be Run; it contains Tasks that don't exist: Couldn't retrieve Task "testloop": tasks.tekton.dev "testloop" not found

I am troubleshooting this 🙃

pritidesai · 2021-05-03T19:21:29Z

oh, nevermind, my bad 😭 I didn't enable alpha APIs 🤣

pritidesai · 2021-05-03T19:21:36Z

oh, nevermind, my bad 😭 I didn't enable alpha APIs 🤣

pritidesai · 2021-05-03T19:27:36Z

looks great, thanks @sbwsg
/lgtm

pritidesai · 2021-05-03T19:31:44Z

Enabling the alpha APIs sets the appropriate feature flags:

  EnableTektonOCIBundles: (bool) true,
  EnableCustomTasks: (bool) true,
  EnableAPIFields: (string) (len=5) "alpha"

ghost · 2021-05-03T19:47:17Z

Awesome, thanks for taking the time to review and try it out so thoroughly @pritidesai !

ghost added the kind/misc Categorizes issue or PR as a miscellaneuous one. label Apr 29, 2021

ghost added this to the Pipelines 0.24 milestone Apr 29, 2021

ghost requested a review from afrittoli April 29, 2021 20:03

tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Apr 29, 2021

tekton-robot requested review from dlorenc and vdemeester April 29, 2021 20:03

tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 29, 2021

ghost changed the title ~~Enable Bundles and Custom Tasks when alpha feature gate is set to "alpha"~~ Enable Bundles and Custom Tasks when feature gate is set to "alpha" Apr 29, 2021

afrittoli reviewed Apr 30, 2021

View reviewed changes

tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 30, 2021

vdemeester approved these changes Apr 30, 2021

View reviewed changes

tekton-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 30, 2021

afrittoli reviewed Apr 30, 2021

View reviewed changes

tekton-robot assigned afrittoli Apr 30, 2021

tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 30, 2021

tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Apr 30, 2021

tekton-robot assigned pritidesai May 3, 2021

tekton-robot added the lgtm Indicates that a PR is ready to be merged. label May 3, 2021

tekton-robot merged commit 565c55b into tektoncd:main May 3, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enable Bundles and Custom Tasks when feature gate is set to "alpha" #3908

Enable Bundles and Custom Tasks when feature gate is set to "alpha" #3908

ghost commented Apr 29, 2021

tekton-robot commented Apr 29, 2021

tekton-robot commented Apr 29, 2021

tekton-robot commented Apr 29, 2021

tekton-robot commented Apr 29, 2021

afrittoli left a comment

afrittoli Apr 30, 2021

ghost Apr 30, 2021

afrittoli Apr 30, 2021

vdemeester left a comment

tekton-robot commented Apr 30, 2021

tekton-robot commented Apr 30, 2021

ghost commented Apr 30, 2021 •

edited by ghost

Loading

tekton-robot commented Apr 30, 2021

ghost commented Apr 30, 2021

tekton-robot commented Apr 30, 2021

afrittoli left a comment

afrittoli commented Apr 30, 2021

ghost commented Apr 30, 2021

tekton-robot commented Apr 30, 2021

ghost commented Apr 30, 2021

pritidesai commented May 3, 2021

pritidesai commented May 3, 2021

pritidesai commented May 3, 2021

pritidesai commented May 3, 2021

pritidesai commented May 3, 2021

ghost commented May 3, 2021

Enable Bundles and Custom Tasks when feature gate is set to "alpha" #3908

Enable Bundles and Custom Tasks when feature gate is set to "alpha" #3908

Conversation

ghost commented Apr 29, 2021

Changes

Submitter Checklist

Release Notes

tekton-robot commented Apr 29, 2021

tekton-robot commented Apr 29, 2021

tekton-robot commented Apr 29, 2021

tekton-robot commented Apr 29, 2021

afrittoli left a comment

Choose a reason for hiding this comment

afrittoli Apr 30, 2021

Choose a reason for hiding this comment

ghost Apr 30, 2021

Choose a reason for hiding this comment

afrittoli Apr 30, 2021

Choose a reason for hiding this comment

vdemeester left a comment

Choose a reason for hiding this comment

tekton-robot commented Apr 30, 2021

tekton-robot commented Apr 30, 2021

ghost commented Apr 30, 2021 • edited by ghost Loading

tekton-robot commented Apr 30, 2021

ghost commented Apr 30, 2021

tekton-robot commented Apr 30, 2021

afrittoli left a comment

Choose a reason for hiding this comment

afrittoli commented Apr 30, 2021

ghost commented Apr 30, 2021

tekton-robot commented Apr 30, 2021

ghost commented Apr 30, 2021

pritidesai commented May 3, 2021

pritidesai commented May 3, 2021

pritidesai commented May 3, 2021

pritidesai commented May 3, 2021

pritidesai commented May 3, 2021

ghost commented May 3, 2021

ghost commented Apr 30, 2021 •

edited by ghost

Loading