-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a nodeAffinity rule to the controller and webhook deployments #3909
Add a nodeAffinity rule to the controller and webhook deployments #3909
Conversation
This commit prevents controller and webhook pods from being scheduled on Windows nodes. Without these affinity rules, the controller or webhook will fail to deploy to a cluster if they are scheduled on a Windows node by Kubernetes. There is no need for these two components to run on Windows nodes for Tekton to support mixed Linux + Windows clusters.
|
Hi @aiden-deloryn. Thanks for your PR. I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbwsg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/retest |
Changes
This commit prevents controller and webhook pods from being
scheduled on Windows nodes. Without these affinity rules, the
controller or webhook will fail to deploy to a cluster if they
are scheduled on a Windows node by Kubernetes.
There is no need for these two components to run on Windows nodes
for Tekton to support mixed Linux + Windows clusters.
Related:
Issue - #1826
TEP - tektoncd/community#383
/kind misc
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
Release Notes