Don't rely on condition ordering. #4209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed a few places in the metrics code that was relying on `Conditions[0]` to access the `Succeeded` condition. Generally we try to sort the conditions to ensure determinism across reconciles, and our sorting generally puts the summary condition (Ready, Succeeded) first, but this is mostly for UX and not something the consuming code should rely upon. While I think it's extremely unlikely that this behavior will change, I believe that the code is much more readable this way because it no longer assumes the reader knows about the sorting or has the expectation that the `Succeeded` condition is always first.
tekton-robot
added
release-note-none
tekton-robot
added
the
size/S
mattmoor
changed the title
|
/easycla |
|
Yay, at least closing/reopening fixes EasyCLA 😁 |
vdemeester
approved these changes
Sep 2, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed a few places in the metrics code that was relying on
Conditions[0]to access theSucceededcondition. Generally we try to sort the conditions to ensure determinism across reconciles, and our sorting generally puts the summary condition (Ready, Succeeded) first, but this is mostly for UX and not something the consuming code should rely upon.While I think it's extremely unlikely that this behavior will change, I believe that the code is much more readable this way because it no longer assumes the reader knows about the sorting or has the expectation that the
Succeededcondition is always first./kind cleanup
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
Release Notes