Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to k8s 1.12.6 and pkg @ HEAD #662

Merged
merged 1 commit into from
Mar 25, 2019
Merged

Update to k8s 1.12.6 and pkg @ HEAD #662

merged 1 commit into from
Mar 25, 2019

Conversation

vdemeester
Copy link
Member

Changes

I had to pin a ton of packages to get things working. In every case I basically just pinned the version in knative/serving.

This also makes a variety of updates to the e2e tests to track changes in the upstream testing libraries.

Closes #659

cc @mattmoor I stole your commit message 😹
cc @imjasonh @bobcatfish

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide
for more details.

Release Notes

Bump kubernetes dependecies to 1.12.6

@googlebot googlebot added the cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit label Mar 22, 2019
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 22, 2019
vdemeester
vdemeester commented Mar 22, 2019
View reviewed changes
Gopkg.toml
@@ -17,21 +17,21 @@ required = [
name = "gopkg.in/yaml.v2"
version = "v2.2.1"

[[constraint]]
[[override]]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to bump go-containerregistry to 1.12.6 for moving those back to constraint

@imjasonh
Copy link
Member

/lgtm

Thanks! 🎉

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 22, 2019
@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Mar 22, 2019
@imjasonh
Copy link
Member

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 22, 2019
@bobcatfish
Copy link
Collaborator

I think this might be a legit race condition due to changes in how logs in tests with this update:

I0322 17:17:40.950] ==================
I0322 17:17:40.950] WARNING: DATA RACE
I0322 17:17:40.950] Write at 0x00c0000ce138 by goroutine 68:
I0322 17:17:40.950]   flag.(*FlagSet).Parse()
I0322 17:17:40.950]       /usr/local/go/src/flag/flag.go:967 +0x42
I0322 17:17:40.951]   github.com/tektoncd/pipeline/test.initializeLogsAndMetrics()
I0322 17:17:40.951]       /usr/local/go/src/flag/flag.go:998 +0xc2
I0322 17:17:40.951]   github.com/tektoncd/pipeline/test.setup()
I0322 17:17:40.951]       /go/src/github.com/tektoncd/pipeline/test/init_test.go:48 +0xa3
I0322 17:17:40.951]   github.com/tektoncd/pipeline/test.TestGitPipelineRun()
I0322 17:17:40.951]       /go/src/github.com/tektoncd/pipeline/test/git_checkout_test.go:45 +0xdb
I0322 17:17:40.951]   testing.tRunner()
I0322 17:17:40.951]       /usr/local/go/src/testing/testing.go:865 +0x163

:(

@bobcatfish
Copy link
Collaborator

I'll do a bit of investigation, we can probably stop using those log libs in the tests entirely 😇

@vdemeester
Update to k8s 1.12.6 and pkg @ HEAD
ba764ab 
I had to pin a ton of packages to get things working.  In every case I basically just pinned the version in knative/serving.

This also makes a variety of updates to the e2e tests to track changes in the upstream testing libraries.

Signed-off-by: Vincent Demeester <[email protected]>
@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Mar 25, 2019
@nader-ziada
Copy link
Member

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 25, 2019
@tekton-robot tekton-robot merged commit c6a1013 into tektoncd:master Mar 25, 2019
@vdemeester vdemeester deleted the bump-deps branch March 25, 2019 15:05
bobcatfish
bobcatfish reviewed Mar 25, 2019
View reviewed changes
test/cancel_test.go
@@ -136,7 +134,7 @@ func TestTaskRunPipelineRunCancel(t *testing.T) {
t.Errorf("Error waiting for PipelineRun `pear` to finished: %s", err)
}

logger.Infof("Waiting for TaskRuns in PipelineRun %s in namespace %s to be cancelled", "pear", namespace)
t.Logf("Waiting for TaskRuns in PipelineRun %s in namespace %s to be cancelled", "pear", namespace)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's actually one problem with using t.Logf in these integration tests: afaik the output is buffered, so if you run the test locally, you won't see the output until the test is done (e.g. maybe 5+ min later) :S

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobcatfish bobcatfish bobcatfish left review comments

@imjasonh imjasonh Awaiting requested review from imjasonh

Assignees

@imjasonh imjasonh

@nader-ziada nader-ziada

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@vdemeester @tekton-robot @imjasonh @bobcatfish @nader-ziada @googlebot