Require ko >= 0.1 and simplify entrypoint copy container args
#686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In tektoncd#605, we required that `ko` was recent enough to be *guaranteed* to have `/ko-app/{app}` (see google/go-containerregistry#380). As we now point to `google/ko` and as we have a `ko` release (v0.1), we can require this version for development. Given the requirement above, we can simplify the `entrypoint` copy container `args`. Signed-off-by: Vincent Demeester <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
googlebot
added
the
cla: yes
tekton-robot
added
the
size/S
|
/lgtm |
|
/test pull-tekton-pipeline-integration-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
In #605, we required that
kowas recent enough to be guaranteed tohave
/ko-app/{app}(see google/go-containerregistry#380). As we nowpoint to
google/koand as we have akorelease (v0.1), we canrequire this version for development.
Given the requirement above, we can simplify the
entrypointcopycontainer
args.cc @pivotal-nader-ziada
Signed-off-by: Vincent Demeester [email protected]
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
[ ] Includes tests (if functionality changed/added)See the contribution guide
for more details.