Partially addresses #1908 #2137
Conversation
|
Hi, Please read our contributing policy. You'll need to make a pull request with the "Signed-off-by:" signature being the last line of your commit message, like it is described in sign your work section. That will grant your work into the public domain. (See travis build) |
Signed-off-by: Andreas Angerer <[email protected]> (github: wa4557)
|
Unfortunately I've changed the way (the place where) the libraries are loaded, new version is available in the dev branch -- so this pull request won't merge. But I think I can add this by myself. |
|
Fine with me, as long as the feature gets added :) |
| else{ | ||
| loadPixbuf(_trayIconImageGen()); | ||
| _trayIcon = ps_gtk_status_icon_new_from_pixbuf(_trayPixbuf); | ||
| } |
There was a problem hiding this comment.
You've replaced a ..set_from_pixbuf(_trayIcon) call with a trayIcon = ...new_from...(), which means you create each time a new icon, just forgetting a pointer to the old one -- this should cause memory leaks and other bugs (for example, you don't connect callbacks, like it is done on 792 (old) / 820 (new) line. I think you need not only ..._new_from_file(), but both that one and ..._set_from_file().
|
I've added such code to the dev branch in the new files. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This allows changing the tray icon, like it was before, by changing icons in ~/.TelegramDesktop/tdata/ticons. Cf. #1908