Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use system icon theme and increase icon size #7111

Merged
merged 1 commit into from
Jan 31, 2020

Conversation

ilya-fedin
Copy link
Contributor

@ilya-fedin ilya-fedin commented Jan 30, 2020

Can help with #3216, but for larger icons App::wnd()->iconWithCounter should be reworked :(
Fixes #1908


QString iconThemeName = QIcon::themeName();
QString iconName = (counter > 0)
? (muted ? "telegram-mute-panel" : "telegram-attention-panel")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
? (muted ? "telegram-mute-panel" : "telegram-attention-panel")
? qsl("telegram-%1-panel").arg(muted ? "mute" : "attention")

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@ilya-fedin ilya-fedin force-pushed the system-tray-icon branch 2 times, most recently from 3af5c66 to f59d334 Compare January 30, 2020 10:36
@john-preston john-preston merged commit 2807c5e into telegramdesktop:dev Jan 31, 2020
@john-preston
Copy link
Member

Thanks!

@AndydeCleyre
Copy link
Contributor

Will icons in the ticons folder, if found, still take precedence?

@ilya-fedin
Copy link
Contributor Author

No, they will be used only on appindicator

@AndydeCleyre
Copy link
Contributor

@ilya-fedin isn't the appindicator what I'm talking about? In my case I mean the systray icon on plasma desktop.

@ilya-fedin
Copy link
Contributor Author

No, appindicator is used only on gnome, pantheon and unity currently

@varlesh
Copy link

varlesh commented Feb 13, 2020

@ilya-fedin Скажу по-русски, боюсь знания моего енглиша не хватит.
Во-первых, это похвально за интеграцию трея и системных значок, но юзать сейчас это не удобно. Во-вторых неужели QSystemTray не умеет в HiDPI? Зачем лочить размер значка в 48px, ведь для большинства юзеров (те, кто не использует HiDPI-экраны) значок будет размыт, потому что 48px уменьшается до 22px (это дефолтный размер практически во всех ДЕ). И как ранее писали проблема HiDPI скорее всего кроется в png, думаю с svg все проблемы уйдут. Так же у плазмы есть опция скаллинга PLASMA_USE_QT_SCALING и для QT5 тоже QT_AUTO_SCREEN_SCALE_FACTOR, возможно стоит о них подумать как о хаке или обходе.

Третье, значок badge захардкорен. Выглядит это странно - половина работает, половина нет. Смысл тогда в такой интеграции? Может добавить кнопку отключения этого badge и вместо нее юзать обычный telegram-attention-panel? (извиняюсь, нашел опцию)

@ilya-fedin
Copy link
Contributor Author

ilya-fedin commented Feb 13, 2020

Скажу по-русски, боюсь знания моего енглиша не хватит.

Дай телеграм, не будем народ смущать. Мой - @IlyaFedin.
Возможно, на некоторые вопросы ответит этот пост.

@ilya-fedin ilya-fedin deleted the system-tray-icon branch February 16, 2020 08:02
@github-actions
Copy link

github-actions bot commented Mar 4, 2021

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make tray icon themeable
6 participants