Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix nightly build because of missing google-cloud-storage #1238

Merged
merged 1 commit into from
Dec 18, 2020
Merged

fix nightly build because of missing google-cloud-storage #1238

merged 1 commit into from
Dec 18, 2020

Conversation

vnghia
Copy link
Contributor

@vnghia vnghia commented Dec 18, 2020 •
edited
Loading

@yongtang

Sorry for the back and forth. I did not notice it since it was skipped in the last PR.

yongtang
yongtang approved these changes Dec 18, 2020
View reviewed changes
Copy link
Member

@yongtang yongtang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yongtang yongtang merged commit 49a84ce into tensorflow:master Dec 18, 2020
@vnghia vnghia deleted the gcs-testbench branch December 18, 2020 14:34
@vnghia
Copy link
Contributor Author

vnghia commented Dec 18, 2020

@yongtang
The API Compatibility still fails on e2bb58f. AFAIK, nightly build will use the wheel package from yesterday so it could result in a regression between master and nightly. I am watiting for other builds to see if they pass or not.

@yongtang
Copy link
Member

Thanks @vnvo2409 for the update

@vnghia
Copy link
Contributor Author

vnghia commented Dec 18, 2020 •
edited
Loading

@yongtang

FYI, both Linux 3.7 and Linux 3.8 are passing in 4a73f60. So there are nothing to worry about. All nightly are pushed to the server. I suppose API Compatibility won't fail next time.

i-ony pushed a commit to i-ony/io that referenced this pull request Jan 22, 2021
@vnghia @i-ony
fix nightly build because of missing google-cloud-storage (tensorfl…
b3b5af2 
…ow#1238)
i-ony pushed a commit to i-ony/io that referenced this pull request Feb 8, 2021
@vnghia
fix nightly build because of missing google-cloud-storage (tensorfl…
04623aa 
…ow#1238)
michaelbanfield pushed a commit to michaelbanfield/io that referenced this pull request Mar 30, 2021
@vnghia @michaelbanfield
fix nightly build because of missing google-cloud-storage (tensorfl…
04d6913 
…ow#1238)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yongtang yongtang yongtang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vnghia @yongtang