Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fail-fast: false to API Compatibility GitHub Actions #1246

Merged
merged 1 commit into from
Dec 23, 2020

Conversation

yongtang
Copy link
Member

@yongtang yongtang commented Dec 22, 2020

This PR adds fail-fast: false to API Compatibility GitHub Actions.
The main reason is to make sure if any job fails, the parallel jobs
within the same matrix of the workflow can continue. The API Compatibility
is to see how our plugin binaries match with different versions
and as such we want to see the whole compatibility matrix results.

Signed-off-by: Yong Tang [email protected]

This PR adds `fail-fast: false` to API Compatibility GitHub Actions.
The main reason is to make sure if any job fails, the parallel jobs
within the same matrix of the workflow can continue. The API Compatibility
is to see how our plugin binaries match with different versions
and as such we want to see the whole compatibility match up results.

Signed-off-by: Yong Tang <[email protected]>
Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The downside of fail-fast is that contributors would no longer be able to see all remaining errors and additional build time might be wasted since they need to push a commit to fix this first before running the rest of the tests.

@yongtang
Copy link
Member Author

@terrytangyuan Yes that is why we set fail-fast to false.

Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I see. I thought we were doing the opposite in this PR. LGTM then.

@terrytangyuan terrytangyuan merged commit 0065f95 into tensorflow:master Dec 23, 2020
@yongtang yongtang deleted the api-check branch December 23, 2020 03:10
@vnghia
Copy link
Contributor

vnghia commented Dec 23, 2020

@yongtang

Linux 3.8 + tf-nightly:tensorflow-io==0.17.0 failed because gcs filesystem does not work correctly with tensorflow_io==0.17.0 ( because google-cloud-cpp does not work with libcurl <= 7.68.0 ). If we want to have a green HEAD, I think we have to remove test_gcs_eager.py in the API compatibility for now.

i-ony pushed a commit to i-ony/io that referenced this pull request Jan 22, 2021
…w#1246)

This PR adds `fail-fast: false` to API Compatibility GitHub Actions.
The main reason is to make sure if any job fails, the parallel jobs
within the same matrix of the workflow can continue. The API Compatibility
is to see how our plugin binaries match with different versions
and as such we want to see the whole compatibility match up results.

Signed-off-by: Yong Tang <[email protected]>
i-ony pushed a commit to i-ony/io that referenced this pull request Feb 8, 2021
…w#1246)

This PR adds `fail-fast: false` to API Compatibility GitHub Actions.
The main reason is to make sure if any job fails, the parallel jobs
within the same matrix of the workflow can continue. The API Compatibility
is to see how our plugin binaries match with different versions
and as such we want to see the whole compatibility match up results.

Signed-off-by: Yong Tang <[email protected]>
michaelbanfield pushed a commit to michaelbanfield/io that referenced this pull request Mar 30, 2021
…w#1246)

This PR adds `fail-fast: false` to API Compatibility GitHub Actions.
The main reason is to make sure if any job fails, the parallel jobs
within the same matrix of the workflow can continue. The API Compatibility
is to see how our plugin binaries match with different versions
and as such we want to see the whole compatibility match up results.

Signed-off-by: Yong Tang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants