-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fail-fast: false
to API Compatibility GitHub Actions
#1246
Conversation
This PR adds `fail-fast: false` to API Compatibility GitHub Actions. The main reason is to make sure if any job fails, the parallel jobs within the same matrix of the workflow can continue. The API Compatibility is to see how our plugin binaries match with different versions and as such we want to see the whole compatibility match up results. Signed-off-by: Yong Tang <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The downside of fail-fast is that contributors would no longer be able to see all remaining errors and additional build time might be wasted since they need to push a commit to fix this first before running the rest of the tests.
@terrytangyuan Yes that is why we set |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I see. I thought we were doing the opposite in this PR. LGTM then.
|
…w#1246) This PR adds `fail-fast: false` to API Compatibility GitHub Actions. The main reason is to make sure if any job fails, the parallel jobs within the same matrix of the workflow can continue. The API Compatibility is to see how our plugin binaries match with different versions and as such we want to see the whole compatibility match up results. Signed-off-by: Yong Tang <[email protected]>
…w#1246) This PR adds `fail-fast: false` to API Compatibility GitHub Actions. The main reason is to make sure if any job fails, the parallel jobs within the same matrix of the workflow can continue. The API Compatibility is to see how our plugin binaries match with different versions and as such we want to see the whole compatibility match up results. Signed-off-by: Yong Tang <[email protected]>
…w#1246) This PR adds `fail-fast: false` to API Compatibility GitHub Actions. The main reason is to make sure if any job fails, the parallel jobs within the same matrix of the workflow can continue. The API Compatibility is to see how our plugin binaries match with different versions and as such we want to see the whole compatibility match up results. Signed-off-by: Yong Tang <[email protected]>
This PR adds
fail-fast: false
to API Compatibility GitHub Actions.The main reason is to make sure if any job fails, the parallel jobs
within the same matrix of the workflow can continue. The API Compatibility
is to see how our plugin binaries match with different versions
and as such we want to see the whole compatibility matrix results.
Signed-off-by: Yong Tang [email protected]