Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adblock mode causes memory issues; "In-Player" fixes memory leakage #1187

Closed
DereC4 opened this issue Jun 30, 2023 · 6 comments · Fixed by #1235
Closed

Adblock mode causes memory issues; "In-Player" fixes memory leakage #1187

DereC4 opened this issue Jun 30, 2023 · 6 comments · Fixed by #1235
Labels
fix-available A fix to the issue is available in a new version

Comments

@DereC4
Copy link
Contributor

DereC4 commented Jun 30, 2023

The Problem

Recent memory accumulation events have been reported. One solution working for me and a majority of users was to change the Adblock plugin mode to "In-Player" from "with blocklists"

image

My Findings

After running multi-hour tests with the Windows Performance Monitor, RAM usage seems to be stable (fig 1) using "in-player", but sees an accumulation of memory over time (fig 2) using "with blocklists". These findings correspond with the smooth experience while using "in-player" but laggy experience (after a period of time) using "with blocklists".

fig 1.

Performance Monitor 6_30_2023 04_02_24 PM

fig 2.

Performance Monitor 6_30_2023 04_02_28 PM

Related #1158 , #1147 , #1162

@th-ch
Copy link
Owner

th-ch commented Jul 4, 2023

👋 Hey @DereC4, thanks for reporting! Regarding the linked issues, is the memory leak only lead to the ad plugin and the "with blocklists" setting? One idea that comes to mind would be switching the default to "in player" if it can help people

@DereC4
Copy link
Contributor Author

DereC4 commented Jul 12, 2023

Oops sorry for the delay I've been on the other side of the globe, but it seems that the in player default would help fix a lot. Could you explain how the blocklists works and how it may be contributing to a memory leak? I thought it would just load in a predefined list and check it for every song.

👋 Hey @DereC4, thanks for reporting! Regarding the linked issues, is the memory leak only lead to the ad plugin and the "with blocklists" setting? One idea that comes to mind would be switching the default to "in player" if it can help people

@mistermatrix24
Copy link

Disabling adblocker all together has greatly improved performance. I'm curious, I would only need adblocker if I didn't have a paid YT Music subscription right?

@DereC4
Copy link
Contributor Author

DereC4 commented Jul 19, 2023

Disabling adblocker all together has greatly improved performance. I'm curious, I would only need adblocker if I didn't have a paid YT Music subscription right?

Youtube Music Premium allows you "to listen to music ad-free, offline & with your screen off" so that makes sense

@paulo-roger
Copy link

Just had a memory leak problem, I am on Linux Manjaro. I am gonna test without the adblocker to see if this fixes the issue.

@DereC4
Copy link
Contributor Author

DereC4 commented Oct 7, 2023

neat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix-available A fix to the issue is available in a new version
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants