[crossfade] add menu options #1065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
th-ch
approved these changes
Mar 14, 2023
th-ch
approved these changes
Mar 14, 2023
Araxeus
force-pushed
the
add-crossfade-menu-options
branch
from
3d398fe to
9f9e991
Compare
|
btw @th-ch maybe the default |
Araxeus
force-pushed
the
add-crossfade-menu-options
branch
from
bd27f23 to
9c64d5d
Compare
* enable onwheel in number inputs * enable wheel event on keybind prompt
Araxeus
force-pushed
the
add-crossfade-menu-options
branch
from
9c64d5d to
9d6a78b
Compare
TODO: replace all `webcontents.send ` with `sendToFront = require('../providers/app-controls')`
this primarily allows front.js to have an up to date config without requesting it over ipc every second for example the crossfade plugin uses its `options.secondsBeforeEnd` every second - so `subscribeAll` would be much more efficient in this case
Araxeus
force-pushed
the
add-crossfade-menu-options
branch
from
e488c1c to
7b8143d
Compare
Araxeus
force-pushed
the
add-crossfade-menu-options
branch
from
7b8143d to
55a442e
Compare
th-ch
approved these changes
Apr 4, 2023
This was referenced Apr 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1046
This PR also improve the new dynamic config, and implements it in the crossfade plugin
create
sendToFront()– 212009aThis is done to avoid the need for a specific browserWindow
TODO: replace all
webcontents.sendin the app withsendToFront = require('../providers/app-controls')add
subscribeandsubscribeAllto config – 648d102this primarily allows front.js to have an up to date config without requesting it over ipc every second.
for example, the crossfade plugin uses its
options.secondsBeforeEndevery second - sosubscribeAllwould be much more efficient in this caseuse new dynamic config – 2ad097c