Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added function to toggle resuming of last song when app starts #177

Merged
merged 1 commit into from
Mar 4, 2021
Merged

Added function to toggle resuming of last song when app starts #177

merged 1 commit into from
Mar 4, 2021

Conversation

NNowakowski
Copy link
Contributor

Implemented option to toggle the resume behaviour as requested in #161

@ashirbhallalevine
Copy link

@NNowakowski Which toggle option is this and should it be available if I have auto-updates turned on?

@NNowakowski
Copy link
Contributor Author

@NNowakowski Which toggle option is this and should it be available if I have auto-updates turned on?

This request wasn't merged yet. Once it gets added to the codebase it should be available with the next update following afterwards.

@ashirbhallalevine
Copy link

@NNowakowski Which toggle option is this and should it be available if I have auto-updates turned on?

This request wasn't merged yet. Once it gets added to the codebase it should be available with the next update following afterwards.

Ah, I see. My bad, I'm fairly new to GitHub. And now I also see the "files changed" tab which explains where/how the change will be implemented. Thank you for writing up the changes and responding to my question so quickly!

@NNowakowski
Copy link
Contributor Author

@NNowakowski Which toggle option is this and should it be available if I have auto-updates turned on?

This request wasn't merged yet. Once it gets added to the codebase it should be available with the next update following afterwards.

Ah, I see. My bad, I'm fairly new to GitHub. And now I also see the "files changed" tab which explains where/how the change will be implemented. Thank you for writing up the changes and responding to my question so quickly!

No problem. It's a feature I wanted to see aswell so seeing your request gave me the push I needed to implement this :p

Copy link
Owner

@th-ch th-ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just 2 small fixes, I will make a quick follow up to address them - thanks for the contribution, merging!

@@ -111,7 +111,8 @@ function createMainWindow() {
win.maximize();
}

win.webContents.loadURL(config.get("url"));
const urlToLoad = config.get("resumeOnStart") ? config.get("url") : "https://music.youtube.com";
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: root url could be imported from default config

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small typo: option is named resumeSongOnStart in other places and not resumeOnStart

@th-ch th-ch merged commit 0dcf820 into th-ch:master Mar 4, 2021
@NNowakowski NNowakowski deleted the resume-last-song-on-start branch March 4, 2021 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants