[Plugin] taskbar-mediacontrol (for Windows) #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add UI Control to windows taskbar preview
using win.minimize() and win.setSkipTaskbar(bool) instead of win.hide() / win.show()
instead of changing source code
(was deleted by accident)
Araxeus
changed the title
* Added Discord timeout
* Add getOptions in plugin util
* Mutex in ffmpeg conversion (only supports one command at a time)
* Add menu customization in plugin system
* Add ytpl package (playlist info)
* Handle ffmpeg metadata flags when metadata is not present
* Only use artist in file name if present
* Export sendError method
* Handle image not present in metadata util
* Add downloader utils (getFolder and default menu label)
* Pass (optional) existing metadata and subfolder in mp3 converter
* Add listener to download playlist
* Add custom menu in downloader plugin ("download playlist" item)
* nit: fix main CSS style
* Only set the "enable" item in menu if plugin not enabled
* Navigation plugin: inject HTML once CSS is loaded
Co-authored-by: Sem Visscher <[email protected]>
Co-authored-by: TC <[email protected]>
th-ch
approved these changes
Mar 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add UI Control to windows taskbar preview (official name is Thumbar)
Closes #107
(had to add img's for icons as per win32 api rules)
There seems to be a bug in electron - after
window.hide()is called, the Thumbar disappears and seems to just break (cant show it again)I reported that bug to them (will be fixed in next electron version)
but since we are using Electron 11.xx - my local fix for the problem is using
win.minimize(); win.setSkipTaskbar(true);instead of
window.hide();Tested it and it works great now :)
EDIT:
uses playPause() function to control play state - which means it currently has the same conflict as Play/Pause in tray menu:
autoConfirmWhenPaused plugin doesn't allow pausing when window is minimized/hidden