Menu tweaks

[Araxeus]

Follows-up PR #215

commit order below is non-chronological, ordered for readability

• 2b3a20c :

  • Tray menu doesn't use mainTemplate anymore - added instead just a restart button
    🔽
    That fixes the visual bug that cause desync between checkbox/radio buttons in tray menu and main app menu
    (could be tweaked, but I'm not sure if any other buttons are needed there)

• 80a7d2c :

  • Remove roles from main menu template (since their original goal was to minimize code, but it ended up being double the length), it also obviously fixes compatibility issues with in-app-menu

• 5524a14 :

  • Declutter mainTemplate by moving advanced options to dedicated submenu, (also removed advanced options button from plugin submenu, since it already exists in another menu - and isn't directly related to plugins)

---

• a194046 .

  • using win.once() instead of win.on in multiple places fixes callbacks being called twice and frees up redundant listeners

• 2162052 :

  • Fixes bugs with css styling of in-app-menu and made scrollbar thumb gray to be more in theme

• 28d366a Fix a critical bug ⚠️ :
  it seems there is an unknown bug with in-app-menu causing did-fail-load to be called with error code -3 , its seems to be some kind of false positive (it doesn't actually fail to load anything and also error code -3 means "ABORTED" )

so now it only loads error.html if not in this exact false-positive case (in-app-menu active + error code -3)

When a song started to play, did-fail-load was called - resulting in displaying error.html
I don't understand why it happened it the first place, and how it works. but it's the only thing that fixed it

---

Sorry that it ended up being a long PR. I tried making it readable.
If needed, I could split it

[th-ch]

Some small nits but otherwise looks good! Removing plugins from the tray menu is a breaking change but it simplifies the code and not sure it was very useful (it's still possible to show the app and the main menu when changing plugins).
Thanks for the PR, feel free to address the comments, otherwise I can merge it and make the changes as a follow up!

[th-ch]

Left a few additional comments after some testing, feel free to address them, otherwise I am fine merging as is and making changes as a follow up!

[Araxeus]

@th-ch
Thanks for all the feedback !

I just realized this whole front-logger thing fixed the did-fail-load error only because it was throwing that IPC serialize error and then not loading the error page because of it...

There is an unknown bug with in-app-menu causing did-fail-load to be called with error code -3 on song start.
its seems to be some kind of false positive (it doesn't actually fail to load anything and also error code -3 means "ABORTED"? )

ill note again that it happens only in the packaged application

Since I was unable to find the source of the event (anonymous), and it doesn't seem to be an actual error:
changed did-fail-load to only load error.html if not in this exact false-positive case (in-app-menu active + error code -3)

After the last commit, It all works well for me.

[th-ch]

Looks good, thanks for the contribution, merging! ✅