-
Notifications
You must be signed in to change notification settings - Fork 602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Interactive notifications for windows #228
Conversation
Button would not transmit event
Delete notification on windowclosed Refactor notifications.utils.setOption
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok, thanks for the contribution! 2 small nits (feel free to address them), otherwise it should be good to merge!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for the contribution!
This PR adds an option to 'notifications' plugin (only on windows)
The same lib could be used to setup interactive notification for mac, if anyone wants to work on that - Node Notifier
The standard pause button unicode wasn't used, because windows render those media buttons as blue
Because of a bug with the delivery method, appID cannot be set without breaking the button functionality
(it makes returned
data
equalundefined
)so appID will it will always be the default "SnoreToast".
Misc:
Song Icon is resized and cropped to keep original aspect ratio (resizing was really ugly with wide images before)
Made
Notification Priority
menu item show only on linux (since it works only on linux)SongInfoProvider was parsing artist name based on video request , not on song - resulting in buggy artist names.
changed it scrape artist name from playbar (native artist name)
win.once()
instead ofwin.on
fix multiple callbacks being registered