Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ambient-mode): fix ambient-mode overlapping other elements #2609

Merged
merged 1 commit into from
Nov 16, 2024

Conversation

h-banii
Copy link
Contributor

@h-banii h-banii commented Nov 16, 2024

Fixes #2520


before

image

after

image


More screenshots/explanation inside these spoiler tags:

audio-video toggle
.song-button.ytmusic-av-toggle, .video-button.ytmusic-av-toggle {
  z-index: 1;
  background-color: transparent;
}

The z-index brings it above the canvas and the background-color does this:

default (#212121) background-color: transparent
ambient mode image image
no ambient mode image image
side panel
#side-panel.side-panel.ytmusic-player-page {
  z-index: 0;
}
before after
image image

OBS.: The other tabs, lyrics and related, are also fixed by this.

toggle-disabled

the av toggle has a "toggle-disabled" attribute which makes it look faded/disabled, as the name suggests, so I removed it.

WITH toggle-disabled NO toggle-disabled
image image

I don't know how this attribute is actually used by youtube in the official web version (I don't have premium to test).

@JellyBrick JellyBrick added the bug Something isn't working label Nov 16, 2024
@JellyBrick JellyBrick merged commit c231fa7 into th-ch:master Nov 16, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: (ambient mode) Barely visible "Song/Video" toggle
2 participants