fix(discord): Fix Album Art failing on Discord RPC #2666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm worried about adding |
Fair enough, not quite sure about the risks it entails other than access to the locker images. Is it known what exactly |
|
Could you provide thumbnail URL for uploaded tracks? |
JellyBrick
changed the title
JellyBrick
added
fix-available
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the album art for uploaded tracks failing on Discord and appearing as a ? block or a ripped image paper.
Removes a
.splitthat removes all query parameters from the album art links ( removing the query parameter?sqp, necessary to authenticate the image url ) from the songInfo data handler. Unsure why this was added, if this breaks something somewhere else due to these query parameters being necessary to be removed, I would recommend this type of split is done there instead of making it completely inaccessible here.Closes #2247 !