-
Notifications
You must be signed in to change notification settings - Fork 602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
precise-volume plugin fixes & updates #275
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Closed
th-ch
approved these changes
Oct 24, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for the improvement!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a HUD that show current volume
it is displayed when volume percentage change, and fade out after a second
If video is disabled (hide-video plugin enabled)
HUD is displayed in the navbar since its pretty much the only place that is consistently visible
('playbar' have no space for elements when window is small)
Screenshot with hide-video
If video is enabled
HUD is displayed in the top left corner of the video player.
also works when minimized (video is shown in mini-player, volume control and hud works from there)
Screenshot with video
Screenshot with mini-video
Fixed various bugs by using native youtube api to change the volume
Other misc fixes
window.load
event from front instead ofwebContents.did-finish-load
event from back$(#main-panel).style.display == none
(hide-video plugin enabled)