Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(no-google-login): Remove Library icon removal code #3010

Merged
merged 1 commit into from
Feb 28, 2025

Conversation

jippylong12
Copy link
Contributor

This PR removes the code responsible for detecting and removing the library icon in the sidebar. The MutationObserver logic and associated libraryIconPath check have been deleted, ensuring the library button remains unaffected.

  • Not sure why this got looped in with the no-google-login plugin. I'm not sure how remove the Library icon is aligned with the goal of "Remove Google login buttons and links from the interface". The library is not a Google Account link. It's a link specifically to a core feature of the app and any music streaming platform.

#784

@JellyBrick JellyBrick added the enhancement New feature or request label Feb 28, 2025
@JellyBrick JellyBrick changed the title no-google-login Plugin: Remove Library Icon Removal Code fix(no-google-login): Remove Library icon removal code Feb 28, 2025
@JellyBrick JellyBrick merged commit 49ac17a into th-ch:master Feb 28, 2025
6 checks passed
@jippylong12 jippylong12 deleted the no-google-login-show-library branch February 28, 2025 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants