update electron & remote & user agents #515

Araxeus · 2021-12-12T22:12:18Z

Update electron https://www.electronjs.org/blog/electron-16-0#end-of-support-for-12xy
which requires updating the remote package in this app as well as in custom-electron-prompt and custom-electron-titlebar
which caused some downloader bugs that needed fixing in commit baeebd1
Fix for logging in when account is "shadowbanned" (browser not secure error)

fix #507, fix #526, fix #17, fix #8, fix #327

WhiteHusky · 2021-12-13T20:02:55Z

Logging in is still pretty jank. I had to clear my data (or as much as I could), then try to sign in, then switch into my own account, then hard refresh. The home page is, for some reason, still showing the generic home page but now I get access to my library.

I swore there was Chromecast support but I guess I might've dreamt it up.

WhiteHusky · 2021-12-13T20:03:36Z

Correction, now it shows my front page after navigating around.

WhiteHusky · 2021-12-13T20:04:47Z

And now opening and closing it breaks it again. Google really doesn't want us embedding YTM huh?

Araxeus · 2021-12-13T20:07:29Z

@WhiteHusky It really should work now, did you update dependencies using yarn? did you try building and installing?

keliel · 2021-12-13T22:37:46Z

Login worked for me instantly. Although there were no navigation items except for search, after returning back to home page.
Also login screens looked a bit different (old?) compared to what I am currently used to with Google/Youtube.
The package versions you updated here, are the newest ones, right? Or are there any other parameters that might've been missed?

keliel · 2021-12-14T08:18:08Z

For reference, this is what it would look like in the competing YTM app. I noticed that here is says "sign in to continue to Youtube Music", but in case of this PR it shows the "sign into all of google" page and mentions "sign in to continue to Youtube", which might be a hint :)

keliel · 2021-12-14T08:39:36Z

Okay nvm. They are having the same issue now. Seems like this is a common problem suddenly appearing with Electron apps, maybe?

keliel · 2021-12-14T08:57:10Z

Over there the fix also included opening their "guest" login separately without actually using it. That one does in fact look like the one that comes out after this PR here :)

Araxeus · 2021-12-14T16:00:22Z

It is indeed an electron problem that has nothing to do with the app. see electron/electron#22346 (comment)

this PR kinda works for some reason - it will try the first time with the normal mode, then if it fails it switches to the "One account. All of Google" mode, which works but if used then for unknown reasons it breaks the navigation until the app is restarted (but it stays logged in so the only problem is the navigation bug after log in)

keliel · 2021-12-14T17:12:43Z

Is it possible to force a restart after successful login in the second case? If so, I would say that it is an acceptable workaround.

On another note regarding this PR: a273f6f is out of scope in my opinion. Or does it have anything to do with the initial problem or resulting issues? I am guessing the simultaneous update to electron was needed for the remote package to work? (4 major versions is pretty big)

Araxeus · 2021-12-14T17:31:46Z

Is it possible to force a restart after successful login in the second case? If so, I would say that it is an acceptable workaround.

Latest version actually works good for me when built and installed (still buggy in dev mode)

a273f6f is out of scope in my opinion.

Well yes but its just that suddenly with the new electron version player.videoMode_ sometimes doesn't reflect the real value when videoStarted() is called, so I just switched to the old way of checking

update to electron was needed for the remote package to work?

More like the update to the remote package was needed because of the electron update.
That update is for mainly for the 2 following reasons:

Electron 12 is deprecated since 16/11/2021 (and with it the remote module)
Update to electron 16 since there shouldn't be any breaking changes affecting this project except the remote module and that way we get the latest chromium which performs better & more secure & less bugs

Araxeus · 2021-12-14T17:41:48Z

@KIMBUM here are windows binaries with the latest changes
https://www.mediafire.com/folder/fvjiihmu3ka2z/Youtube-Music+useragents-patch+v3

try installing via the setup this time

keliel · 2021-12-14T20:45:59Z

@Araxeus works like you said. First time failed, but second time works fine. Navigation also showed up for me, since reload seemed to happen automatically.

I did notice however, that the disable-autoplay plugin seems to be broken now. Stops each time I try to press play 😞

keliel · 2021-12-14T20:53:43Z

Seems to work some of the time when the tooltip for "press to play" appears, but even though I just reinstalled it, the tooltip is not shown for the first startup 🤨

th-ch

Thanks for the fix, tested on MacOS, looks promising! But I would separate the electron upgrade which might require more work

package.json

index.js

Araxeus · 2021-12-15T17:31:36Z

@th-ch Sorry but I really can't separate it now since remote doesn't work for me anymore no matter what I do
-which means I can't even test another PR without the updated electron version

disable-autoplay plugin seems to be broken now. Stops each time I try to press play

@KIMBUM I actually can't replicate anything? could you check again maybe>

downloader plugins (unrecognized flag --experimental-wasm-bulk-memory + SharedArrayBuffer is not defined are fixed with baeebd1

allow override of useragent in config for more flexibility

@th-ch this useragent isn't really doing much, the actual fix is that when it fails (some accounts are shadowbanned) - it tries again with the original useragent which does work currently if login initially fail

youtube-music/index.js

Lines 185 to 191 in 8f2ed30

    
           win.webContents.session.webRequest.onBeforeSendHeaders((details, cb) => { 
        
           	// this will only happen if login failed, and "retry" was pressed 
        
           	if (win.webContents.getURL().startsWith("https://accounts.google.com") && details.url.startsWith("https://accounts.google.com")){ 
        
           		details.requestHeaders["User-Agent"] = originalUserAgent; 
        
           	} 
        
           	cb({ requestHeaders: details.requestHeaders }); 
        
           });

* --experimental-wasm-bulk-memory * SharedArrayBuffer * getFolder from front * ytdl-core 4.9.2

Araxeus · 2021-12-16T17:23:59Z

Downloader issues are fixed
I've also fixed and updated both custom-electron-prompt&titlebar packages

All thats left is that disable-autoplay bug that I can't personally replicate. can anyone look into it?
windows setup 16/12/2021: https://www.mediafire.com/folder/fvjiihmu3ka2z/Youtube-Music+useragents-patch+v4

Its also worth noting that the portable version of the app / dev version has a bug in those 2 scenarios:

logged in failed, retried with alternate useragent and succedeed
Launched the app (sometimes, about 1/5 times for me)

in which all navbar items disappear except the search button:

No idea why would it ever happen, but it never happens if the app is installed - so maybe whenever you release a new version you should consider not including the portable version or add a warning?

(According to my testing, this bug has no relation to the useragent, which makes sense since installing gets rid of it)

th-ch

Looks good, thanks for the fix and the upgrade! Merging, will release a new version with all the recent changes

Araxeus mentioned this pull request Dec 12, 2021

No login #17

Closed

Araxeus force-pushed the fix-useragents branch 2 times, most recently from 94e8214 to 3425767 Compare December 12, 2021 22:31

update useragents

dd12266

Araxeus force-pushed the fix-useragents branch from 3425767 to dd12266 Compare December 12, 2021 22:56

Araxeus added 4 commits December 13, 2021 01:11

always on useragent

e1e9748

update electron & remote module

4fd683e

fix useragents

2fb4793

use @rozzzly/custom-electron-titlebar

6633243

Araxeus changed the title ~~update user agents~~ update electron & remote & user agents Dec 13, 2021

Araxeus mentioned this pull request Dec 13, 2021

Allow Google Signin #508

Closed

Araxeus added 2 commits December 14, 2021 00:34

use firefox as falllback useragent

c8ba85b

fix video toggle button appearing when in song mode

a273f6f

use session.webRequest.onBeforeSendHeaders for useragent

47ca6e0

th-ch reviewed Dec 14, 2021

View reviewed changes

package.json Show resolved Hide resolved

index.js Show resolved Hide resolved

th-ch reviewed Dec 14, 2021

View reviewed changes

index.js Show resolved Hide resolved

Merge branch 'master' into fix-useragents

4694352

Araxeus mentioned this pull request Dec 15, 2021

[Manjaro] Unsupported Browser #507

Closed

Araxeus added 3 commits December 16, 2021 18:01

update custom-electron-titlebar

3764ce9

fix custom-electron-prompt & remote

49edbf7

downloader fixes

baeebd1

* --experimental-wasm-bulk-memory * SharedArrayBuffer * getFolder from front * ytdl-core 4.9.2

add comment to useragent fix

8f2ed30

Araxeus marked this pull request as ready for review December 20, 2021 14:41

Araxeus mentioned this pull request Dec 24, 2021

Unsupported Browser Issue On Mac #526

Closed

th-ch approved these changes Dec 30, 2021

View reviewed changes

th-ch merged commit 56ac2b3 into th-ch:master Dec 30, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

update electron & remote & user agents #515

update electron & remote & user agents #515

Araxeus commented Dec 12, 2021 •

edited

Loading

WhiteHusky commented Dec 13, 2021

WhiteHusky commented Dec 13, 2021

WhiteHusky commented Dec 13, 2021

Araxeus commented Dec 13, 2021 •

edited

Loading

keliel commented Dec 13, 2021

keliel commented Dec 14, 2021

keliel commented Dec 14, 2021

keliel commented Dec 14, 2021

Araxeus commented Dec 14, 2021 •

edited

Loading

keliel commented Dec 14, 2021

Araxeus commented Dec 14, 2021 •

edited

Loading

Araxeus commented Dec 14, 2021 •

edited

Loading

keliel commented Dec 14, 2021

keliel commented Dec 14, 2021

th-ch left a comment

Araxeus commented Dec 15, 2021 •

edited

Loading

Araxeus commented Dec 16, 2021 •

edited

Loading

th-ch left a comment

update electron & remote & user agents #515

update electron & remote & user agents #515

Conversation

Araxeus commented Dec 12, 2021 • edited Loading

WhiteHusky commented Dec 13, 2021

WhiteHusky commented Dec 13, 2021

WhiteHusky commented Dec 13, 2021

Araxeus commented Dec 13, 2021 • edited Loading

keliel commented Dec 13, 2021

keliel commented Dec 14, 2021

keliel commented Dec 14, 2021

keliel commented Dec 14, 2021

Araxeus commented Dec 14, 2021 • edited Loading

keliel commented Dec 14, 2021

Araxeus commented Dec 14, 2021 • edited Loading

Araxeus commented Dec 14, 2021 • edited Loading

keliel commented Dec 14, 2021

keliel commented Dec 14, 2021

th-ch left a comment

Choose a reason for hiding this comment

Araxeus commented Dec 15, 2021 • edited Loading

Araxeus commented Dec 16, 2021 • edited Loading

th-ch left a comment

Choose a reason for hiding this comment

Araxeus commented Dec 12, 2021 •

edited

Loading

Araxeus commented Dec 13, 2021 •

edited

Loading

Araxeus commented Dec 14, 2021 •

edited

Loading

Araxeus commented Dec 14, 2021 •

edited

Loading

Araxeus commented Dec 14, 2021 •

edited

Loading

Araxeus commented Dec 15, 2021 •

edited

Loading

Araxeus commented Dec 16, 2021 •

edited

Loading