compact: implement native histogram downsampling #8110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Giedrius Statkevičius <[email protected]>
GiedriusS
force-pushed
the
implement_nativehistogram_downsampling
branch
2 times, most recently
from
c39432a to
73ed78c
Compare
Signed-off-by: Giedrius Statkevičius <[email protected]>
GiedriusS
force-pushed
the
implement_nativehistogram_downsampling
branch
from
73ed78c to
e4e7fa2
Compare
yeya24
approved these changes
Feb 21, 2025
| return it.Err() | ||
| } | ||
|
|
||
| // expandHistogramChunkIterator reads all histograms from the iterator and appends them to buf. |
There was a problem hiding this comment.
Comment needs update. expandFloatHistogramChunkIterator
| for _, c := range chks { | ||
| if prevEnc != c.Chunk.Encoding() { |
There was a problem hiding this comment.
If previous encoding is float histogram and current encoding is normal histogram, can we downsample those chunks together since the input is same, float histogram?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update #6350:
Closes #5907.
Closes #6350.