Number of points requested cannot exceed 200 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thataustin
reviewed
Oct 3, 2016
| var options = _.extend({}, forecastDetails, { listLatLon: listLatLon}); | ||
| var url = this._convertOptionsToUrlString('data', options); | ||
| return this._makeCall(url); | ||
| return this._getForecastPerPoint(geoBusinessObjects, forecastDetails, chunkSize); |
There was a problem hiding this comment.
I think the chunkSize could be an internal detail to the getForecastPerPoint function. That function should fetch in chunks and return a flattened version of the results. The next function in the chain doesn't have to know or care that there's a chunk limitation in the _getForecastPerPoint process.
|
Sorry, I just saw this! Holy cow, time to quit using the "Mark all as read" button in Github alerts. |
gracefully handle sites outside of the usa
print url when there is an error handle bad lat lng being first in batch of 200 handle bad lat lng being first in batch of 200 handle bad lat lng being first in batch of 200 handle bad lat lng being first in batch of 200 handle bad lat lng being first in batch of 200
|
@thataustin - good idea with moving chunk size. I did that but I've also added some other stuff since this pull request was originally created: locations outside the NOAA's coverage were causing errors, so I now remove them from the list of lat/lng pairs being processed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOAA will only process weather requests for 200 points at a time. This breaks the list of lat/lon's into batches of 200.
(http://graphical.weather.gov/xml/ about 1/2 way down there is a note about this)
@thataustin - if you want, I can take over this library. Up to you.