Fixes #38155 - Use auto instead of dhcp for ipv6 interfaces #10420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
requested changes
Jan 21, 2025
| @@ -61,11 +61,7 @@ if subnet6 | |||
| network_options.push("--ipv6=#{@iface.ip6}/#{subnet6.cidr}") | |||
| network_options.push("--ipv6gateway=#{subnet6.gateway}") | |||
| elsif subnet6.dhcp_boot_mode? | |||
| if @use_slaac | |||
There was a problem hiding this comment.
The use_slaac option is now unused so it should be removed, as well as the use-slaac parameter. The alternative is to default the parameter to true.
There was a problem hiding this comment.
I think removing the parameter will be less confusing than having
use_slaac = hoast_parameter_true?('use-slaac', true)WDYT?
ShimShtein
force-pushed
the
use_auto_for_ipv6
branch
from
cf11ac5 to
a9950e2
Compare
ShimShtein
force-pushed
the
use_auto_for_ipv6
branch
from
a9950e2 to
ddd03dc
Compare
|
@ekohl ready for another round. Removed the |
|
For other people with merge access: CI is still running as I write this. |
|
Is green, thanks @ShimShtein and @ekohl ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
option
dhcpdoes not use Router Advertisements to configure the network.