Fixes #38223 - host_edit when no inherit button creates error #10447
+5
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Legacy JS
|
Thank you! |
|
We might want to cp it in 3.13, to work around a user can go to the details page / delete the the |
ofedoren
approved these changes
Feb 18, 2025
There was a problem hiding this comment.
Thanks, @MariaAga ! It fixes the issue described in #10265 (comment). Although, I didn't have exact error in console, rather a different one. The "stuck loading" was reproducible. With the patch, the redirection works and with the right URL.
Just FYI, to reproduce it, you should have disabled redirection to the new host details page in settings.
|
cp: #10454 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up on #10265
When editing a host, in foreman core without plugins, there is no inherit button on any of the fields, the causes this error:
Uncaught TypeError: document.querySelector(...) is null host_edit-a353532802cf651d1f8eaecab20ef1d6620e03c07c776b03559e9b18bebc15cf.js:1
for some reasons it makes it so the submit button redirects to the old details page, but still with the edit url
This causes the old details page to load on a loop