Fixes #38229 - Add new template snapshot host for Ubuntu #10451
+71
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Next to ubuntu_autoinst4dhcp (a Ubuntu 20 machine with default host4dhcp config), add a second scenario to cover a more common Ubuntu scenario: ubuntu_autoinstmulti4dhcp. * has two IPv4 NICs * both NICs don't set the identifier When the NIC identifier is not set, the preseed_netplan_generic_interface snippet adds a MAC-based match section which shall be included in snapshot tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds another machine
ubuntu_autoinstmulti4dhcpin order to test a common NIC setup: No identifier is set and two NICs are provided. This aims on testing this part of the networking snippet: https://github.com/theforeman/foreman/blob/develop/app/views/unattended/provisioning_templates/snippet/preseed_netplan_generic_interface.erb#L10This is a common scenario which is currently not covered by our snapshots and shows an issue with the current snippet.
I'm wondering whether we want to test different template/snippet scenarios by adding multiple snapshot hosts like I'm introducing with this PR. I did stumble across #9516 which might make this more elegant by transitioning to traits.