-
Notifications
You must be signed in to change notification settings - Fork 703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jump to channel switcher #3594
Jump to channel switcher #3594
Conversation
d137775
to
6b7e531
Compare
I would say this pretty much ready as it is, except in an ideal world we'd use ctrl+k for the shoctcut. That's what slack, discord, mattermost and others use for this feature. EDIT: If we end up changing shortcuts this should be considered at the same time #2442 |
Do you have any idea how much TheLounge users use colours or formatting? I think IRC users mostly don't use colours and even people using them may be open to changing to another shortcut as they would likely be used to |
Any rebinding of Ctrl-K away from colors should be very carefully considered. It's the de facto standard color shortcut. (For the record, I'm strongly against doing so.) |
Where is it the de-facto standard color shortcut? I cannot remember coming across it in other context than channel switching. |
Granted it's an unscientific sampling, but nearly every client I've ever installed used Ctrl/Cmd+K for colors (mIRC, KVIrc, TL). Search for "irc color ctrl-k" and see for yourself how much newbie documentation references it, e.g. https://en.wikichip.org/wiki/irc/colors and (currently not loading for me) http://www.ircbeginner.com/ircinfo/colors.html |
6b7e531
to
fb08877
Compare
Looks like our component style compiling puts Besides that, this PR seems good to go for me. |
95028c7
to
47f5da6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add the keybind to help window.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Squash and merge 👍
Co-Authored-By: Pavel Djundik <[email protected]>
9f5c47e
to
9e76fe2
Compare
This adds a search box to the sidebar, that can be used to filter and navigate channels. It can be toggled with alt+j.
This is how it looks on the default theme:

Fixes #1454