Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to channel switcher #3594

Merged
merged 5 commits into from
Feb 10, 2020
Merged

Jump to channel switcher #3594

merged 5 commits into from
Feb 10, 2020

Conversation

richrd
Copy link
Member

@richrd richrd commented Dec 16, 2019

This adds a search box to the sidebar, that can be used to filter and navigate channels. It can be toggled with alt+j.

This is how it looks on the default theme:
image

Fixes #1454

@richrd richrd added the Type: Feature Tickets that describe a desired feature or PRs that add them to the project. label Dec 16, 2019
@xPaw xPaw added this to the 4.1.0 milestone Dec 19, 2019
@richrd richrd force-pushed the richrd/jump-to branch 3 times, most recently from d137775 to 6b7e531 Compare December 20, 2019 12:22
@richrd richrd marked this pull request as ready for review January 1, 2020 22:30
@richrd
Copy link
Member Author

richrd commented Jan 4, 2020

I would say this pretty much ready as it is, except in an ideal world we'd use ctrl+k for the shoctcut. That's what slack, discord, mattermost and others use for this feature.
Problem is that ctrl+k is used for color selector, do we want to change that or just go with alt+j or some other less standard shortcut?

EDIT: If we end up changing shortcuts this should be considered at the same time #2442

@Mikaela
Copy link
Contributor

Mikaela commented Jan 5, 2020

Do you have any idea how much TheLounge users use colours or formatting? I think IRC users mostly don't use colours and even people using them may be open to changing to another shortcut as they would likely be used to ctrl+k of the other apps.

@dgw
Copy link
Contributor

dgw commented Jan 5, 2020

Any rebinding of Ctrl-K away from colors should be very carefully considered. It's the de facto standard color shortcut. (For the record, I'm strongly against doing so.)

@Mikaela
Copy link
Contributor

Mikaela commented Jan 5, 2020

Where is it the de-facto standard color shortcut? I cannot remember coming across it in other context than channel switching.

@dgw
Copy link
Contributor

dgw commented Jan 5, 2020

Granted it's an unscientific sampling, but nearly every client I've ever installed used Ctrl/Cmd+K for colors (mIRC, KVIrc, TL). Search for "irc color ctrl-k" and see for yourself how much newbie documentation references it, e.g. https://en.wikichip.org/wiki/irc/colors and (currently not loading for me) http://www.ircbeginner.com/ircinfo/colors.html

@xPaw
Copy link
Member

xPaw commented Jan 17, 2020

Looks like our component style compiling puts jump-to styles above our style.css which is probably not a good idea. Can we tweak the order somehow?

Besides that, this PR seems good to go for me.

Copy link
Member

@xPaw xPaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the keybind to help window.

Copy link
Member

@xPaw xPaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Squash and merge 👍

@richrd richrd merged commit 1fb78d7 into master Feb 10, 2020
@richrd richrd deleted the richrd/jump-to branch February 10, 2020 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature Tickets that describe a desired feature or PRs that add them to the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Jump to" channel switcher
4 participants