Skip to content

Commit

Permalink
fixes #1662
Browse files Browse the repository at this point in the history
  • Loading branch information
aristath committed Nov 25, 2017
1 parent 76d3998 commit b51e747
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 2 deletions.
2 changes: 1 addition & 1 deletion controls/js/src/kirki.js
Original file line number Diff line number Diff line change
Expand Up @@ -407,7 +407,7 @@ var kirki = {
* @returns {void}
*/
init: function( control ) {
var element = jQuery( 'select[data-id="' + control.id + '"' ),
var element = jQuery( 'select[data-id="' + control.id + '"]' ),
multiple = parseInt( element.data( 'multiple' ), 10 ),
selectValue,
selectWooOptions = {
Expand Down
2 changes: 1 addition & 1 deletion controls/views/select.php
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
data.value = [ data.value ];
}
#>
<div class="kirki-input-container" data-id="' + data.id + '">
<div class="kirki-input-container" data-id="{{ data.id }}">
<label>
<# if ( data.label ) { #>
<span class="customize-control-title">{{ data.label }}</span>
Expand Down
1 change: 1 addition & 0 deletions readme.txt
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ If you want to integrate Kirki in your theme or plugin, please read the instruct
* Fix: Allow using tabs & linebreaks when defining elements in the `output` argument [#1659](https://github.com/aristath/kirki/issues/1659)
* Fix: PHP Warning when using `code` controls without a `label` defined [#1658](https://github.com/aristath/kirki/issues/1658)
* Fix: Buttons inside `number` controls were not increasing/decreasing the values [#1648](https://github.com/aristath/kirki/issues/1648)
* Fix: JS error - only on Safari - for Select controls [#1662](https://github.com/aristath/kirki/issues/1662)
* New: Transitioned to a JS-based webfont loader method to load google-fonts instead of using a link.
* New: Moved `select` controls to new JS implementation.
* New: Moved `text` and `textarea` controls (`generic` controls) to new JS implementation.
Expand Down

0 comments on commit b51e747

Please sign in to comment.