Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE]: Modify "mail_from" via GUI settings #926

Closed
manolof opened this issue Jul 21, 2024 · 8 comments
Closed

[FEATURE]: Modify "mail_from" via GUI settings #926

manolof opened this issue Jul 21, 2024 · 8 comments

Comments

@manolof
Copy link
Contributor

manolof commented Jul 21, 2024

Is your feature request related to a problem? Please describe.

It would be very useful to be able to modify the email notifications sender's ("From") address.
Currently, it just takes the receiver address and adds the "+terrariumpi" to the first part of the URL.

mail_from=("TerrariumPI", re.sub(r"(.*)@(.*)", "\\1+terrariumpi@\\2", receiver, 0, re.MULTILINE)),

The problem is that, some email providers like Gmail recognize this as a potential issue:

Screenshot 2024-07-21 at 21 39 25

which makes services like Mailgun, or Smtp2Go fail sporadically.

Describe the solution you'd like

An option in the GUI to specify the "From" address.

@theyosh
Copy link
Owner

theyosh commented Jul 22, 2024

I have updated the code. But you are using docker, so that is a bit harder to test. If you are able/wanting to test this, I can create a development version.

@manolof
Copy link
Contributor Author

manolof commented Jul 22, 2024

I have updated the code. But you are using docker, so that is a bit harder to test. If you are able/wanting to test this, I can create a development version.

I'd be up for it, towards end of the week or beginning of next one though.

Thanks for the quick work on this.

@theyosh
Copy link
Owner

theyosh commented Jul 23, 2024

@manolof
Copy link
Contributor Author

manolof commented Jul 29, 2024

@theyosh thanks, it works!
However, not sure if this is related but, the camera stopped working again.

@theyosh
Copy link
Owner

theyosh commented Jul 29, 2024

More about the camera? I just created a new release, thought all was fixed

@manolof
Copy link
Contributor Author

manolof commented Jul 29, 2024

I was using Bookworm and v4.10.2 on a Raspberry Pi 4 Model B Rev 1.5.
I used development-bookworm.
I will try to downgrade to the stable 4.10.2 and see what happens with the camera.

@theyosh
Copy link
Owner

theyosh commented Jul 29, 2024

Ok, you could also try 4.11.0 in a few seconds. That is the latest release.
I will look into this later today.

@manolof
Copy link
Contributor Author

manolof commented Jul 29, 2024

I upgraded and all good, we are back online 😃 Thanks!

@manolof manolof closed this as completed Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants