[BUG]: day/night confusion

[rossisbudda]

Setup:

• TerrariumPI version: 4.10.2
• Install: manual
• Raspberry PI: 3B+
• OS: raspbian 12 bookworm

Describe the bug
Day switched to night at midnight, even though day was scheduled to switch to night after 18 hours 09:30:-06:30
To Reproduce / Installation steps
I think that setting a day set to >12 hours that spans midnight will yield unexpected relay times. In the screen grabs you can see that 09:30 to 06:30 is in fact 18 hours, yet at midnight a state alteration occurs although not prescribed.

Expected behavior
I would expect the lighting toggle to flip at the prescribed absolute time rather than using midnight as marker. There is no mention of midnight in my config.

I struggle to see why this relay toggled at midnight rather than 3.30am as requested.

Logfiles
terrariumpi.log

[theyosh]

Sorry, but the issue has no information. Could you please put your question in the issue?

[rossisbudda]

Apologies, I misfired then forgot to submit the edit.

…

On Sun, 8 Sep 2024 at 06:46, TheYOSH ***@***.***> wrote: Sorry, but the issue has no information. Could you please put your question in the issue? — Reply to this email directly, view it on GitHub <#948 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AMD3C2VWXSZCWGYF4X7S4YTZVPQBZAVCNFSM6AAAAABN2NUC3CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMZWGU2TMNJQGY> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[rossisbudda]

I include the day/night period settings screen also.

[rossisbudda]

sorry about the messy ticket, all the original post has been cleaned up now 🧽

[theyosh]

I am not sure if I understand your question.

But I guess you have this problem due you 30 minute restart action. That is probably causing some confusion in the timer calculation. So I advise to stop that.
This is not a smart way to detect broken Meross connection.

So disable the restarting of TerrariumPI and see if the lights behave correctly. If that is the case, the restarts are causing some strange side effects.

In order to detect a broken Meross connection, you can make a custom script which reads out a temperature sensor, and when it gets to cold, it will restart TerrariumPI. This is a smarter way of detecting a broken Meross connection.

[theyosh]

On the other hand, this is a nice test case. I think I fixed this issue in code. Do a git pull and restart TerrariumPI.

Keep the restarting crontab in place, and lets see what happens tonight. It should stay on after a restart just after 00:00.

Still, just restarting every 30 seconds is not the handiest way..

[theyosh]

Did you had time to test the latest code with your timer setting? I think the issue should be fixed. A specially with you 30 min crontab restart.

[rossisbudda]

Hi sorry for the delay. I tried a gitpull but it said I had changed a bunch of files and I couldn’t figure it out. I’m a bit of a noob and I didn’t want to upset the cycle of my environment or lose my config as it’s all live and I don’t want to affect the lighting cycle. Completely accept my hack is awful and tbh my extra hack was to disable the crontab during the “post midnight” daytime 12-3.30. Definitely sucks but it worked this far. If I can swap to manual analogue timer soon I would find time do confidently make a fresh install and reconfigure identically, then test. Any advice welcome. Thanks for your patience.

…

On Thu, 12 Sep 2024 at 19:27, TheYOSH ***@***.***> wrote: Did you had time to test the latest code with your timer setting? I think the issue should be fixed. A specially with you 30 min crontab restart. — Reply to this email directly, view it on GitHub <#948 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AMD3C2VHPP4XSYTPKGPRA23ZWHMHRAVCNFSM6AAAAABN2NUC3CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNBWHE3DQNBVGY> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[theyosh]

If you reinstall it, make some backups: https://theyosh.github.io/TerrariumPI/faq/which-files-to-backup/
And restore it like this: https://theyosh.github.io/TerrariumPI/faq/restoring-backup-files/

That should save some time setting it all up.

[rossisbudda]

Ok thanks I did see this but I was a bit hesitant. I’ll try to update better or install fresh tomorrow. Please save the ticket! Thx

…

On Thu, 12 Sep 2024 at 20:05, TheYOSH ***@***.***> wrote: If you reinstall it, make some backups: https://theyosh.github.io/TerrariumPI/faq/which-files-to-backup/ And restore it like this: https://theyosh.github.io/TerrariumPI/faq/restoring-backup-files/ That should save some time setting it all up. — Reply to this email directly, view it on GitHub <#948 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AMD3C2VM5FLFCR5UBRE3SALZWHQXNAVCNFSM6AAAAABN2NUC3CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNBXGAZTMNJQHA> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[theyosh]

And you do not have to reset your SD card. Just move the existing TerrariumPI folder to a temporary name, and just start the TerrariumPI installation with the git pull.

You do not have to complete reinstall the OS. Just re-install TerrariumPI only. Saves a lot of time.

Will keep this issue open. No problem

[rossisbudda]

I have done a manual backup, gitpull, reinstall (4.11.1), restored data and removed my bi hourly crontab. Will report back if the midnight glitch happens or not!

[theyosh]

Ok, but without the crontab, the bug will not happen. But that is OK. As long it is stable for you. That is the most important.

The bug will only happen when you restart TerrariumPI after 00:00 and before 03:00 hours. (in your case, and your timezone)

[rossisbudda]

I will be watching, then try a manual restart after midnight to see if it can reproduce. You're the best!

[rossisbudda]

Hi, I tried it. Restarting the service between 00:00 and 03:30 resumed the day cycle as normal and the lights stayed on :) Thanks again! I think you can close this.

…

On Fri, 13 Sep 2024 at 22:45, TheYOSH ***@***.***> wrote: Ok, but without the crontab, the bug will not happen. But that is OK. As long it is stable for you. That is the most important. The bug will only happen when you restart TerrariumPI after 00:00 and before 03:00 hours. — Reply to this email directly, view it on GitHub <#948 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AMD3C2RBT2NQWBFWBRHVNKDZWNMHFAVCNFSM6AAAAABN2NUC3CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNJQGM2TIMJXGE> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[theyosh]

Thanks for testing. And good to hear the bug is fixed!