Adds checking to see if lights, cooler, heater and sprayer are enable… #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d. Added checking for lights enabled in get_enable so socket server would start
theyosh
added a commit
that referenced
this pull request
Aug 9, 2017
|
Hi, thanks for the pull request. But I think I will not merge it. For the other systems, there is not an error. And your pull request does add checks for the other environment parts, but is never used. So that is not good in my opinion. So, thanks for sending the code, but I will fix it in a different way. |
|
No worries, that was how I fixed but thought a function to check if enabled would be handy to use in other aspects of the code. Unused functions are shit, should have omitted and followed up with another PR. Anyways good work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added checking for lights enabled in get_state which allows socket server to start for an fresh install.