Remove deprecated mac argument for pywemo #808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, thanks for the PR. |
|
Euh, I just see you are the writer of the pywemo package. I want to thank you a bit extra for this. This makes my live so much easier if every body did this. So thanks again! This is really appreciated! |
|
Happy to help! Just trying to make the transition easy and not break TerrariumPI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The next version of pyWeMo will remove the
macargument todevice_from_description. It has been an optional argument since pywemo 0.8.0. TerrariumPI is currently using pywemo version 0.9.2.TerrariumPI/requirements.txt
Line 51 in 79be755
Further context: pywemo/pywemo#367 (in the next release) - Deprecation: Remove the mac address argument