-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Integration with Cumulocity CA #3259
base: main
Are you sure you want to change the base?
feat: Integration with Cumulocity CA #3259
Conversation
Codecov ReportAttention: Patch coverage is Additional details and impacted files📢 Thoughts on this report? Let us know! |
) | ||
} | ||
} | ||
warning!("Will retry in 5 seconds"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One needs to loop only when it makes senses to retry: i.e. the c8y endpoint has been reached but the device has not been registered yet.
Question: does Cumulocity return a specific HTTP status when the device is not registered?
844dc34
to
284c8ee
Compare
284c8ee
to
fba8ed6
Compare
5f284b5
to
5335af8
Compare
Robot Results
|
8ee9b20
to
abfa57e
Compare
abfa57e
to
74c6188
Compare
Renew { | ||
/// CA from which the certificate will be renew | ||
#[arg(value_enum, default_value = "self-signed")] | ||
ca: CertRenewalCA, | ||
|
||
#[clap(subcommand)] | ||
cloud: Option<CloudArg>, | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something is wrong here.
In tedge cert renew c8y
, c8y
can be understood either as the CA and as the cloud profile. Even clap
is confused:
tedge cert renew self-signed c8y --profile test
is correctly interpreted as a request to renew the self-signed certificate used to connect the test c8y tenant- while
tedge cert renew c8y c8y --profile test
leads to an error,clap
incorrectly assuming the default CA (i.e. self-signed) and being then confused by the repeated cloud parameter.
74c6188
to
46d8bd5
Compare
46d8bd5
to
4911dbf
Compare
Signed-off-by: Didier Wenzek <[email protected]>
Signed-off-by: Didier Wenzek <[email protected]>
Signed-off-by: Didier Wenzek <[email protected]>
4911dbf
to
d8ad1bd
Compare
Signed-off-by: Didier Wenzek <[email protected]>
Signed-off-by: Didier Wenzek <[email protected]>
d8ad1bd
to
cdc553c
Compare
Proposed changes
Types of changes
Paste Link to the issue
#3248
Checklist
cargo fmt
as mentioned in CODING_GUIDELINEScargo clippy
as mentioned in CODING_GUIDELINESFurther comments