-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: install tedge tab completions during installation #3407
feat: install tedge tab completions during installation #3407
Conversation
922ab16
to
0a74778
Compare
0a74778
to
1d2a551
Compare
Robot Results
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved.
I only checked things related to zsh
.
Though the system tests include all three shells (bash, zsh and fish) and the profile changes are part of the container definition, so any system test can be used to try it out. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small correction in docs.
1d2a551
to
1d0cc5e
Compare
Proposed changes
Install the shell completions during the
tedge
post installation phase if the detected shell scripts are found.Adding the script as part of the installation allows for a more seamless completion experience as sometimes no setup needs to be done if the user has already enabled shell completion for their preferred shell.
The system test image now includes the shell completion out of the box to help developers during testing and demos.
Note: The shell completion script is added as part of the post installation and not a static file as the clap generated script will use the full path to the binary that called the
tedge completions
command which makes running at build time problematic as it would use the build time path of thetedge
binary instead of the destinations path.Types of changes
Paste Link to the issue
tedge
CLI #3331Checklist
cargo fmt
as mentioned in CODING_GUIDELINEScargo clippy
as mentioned in CODING_GUIDELINESFurther comments