Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat/announcement card #10

Merged
merged 20 commits into from
Jan 31, 2021
Merged

feat/announcement card #10

merged 20 commits into from
Jan 31, 2021

Conversation

new5558
Copy link
Member

@new5558 new5558 commented Jan 27, 2021 •
edited
Loading

  • Installed date-fns and @storybook/addon-knobs (this one is better than storybook's original control)
  • Add Chip and GenEdChip components
  • Add AnnouncementCard component
  • Preview on Storybook

P.S. I'm very new to material-ui krub. Please kindly advice.

@new5558 new5558 requested review from suphon-t and saengowp January 27, 2021 17:16
@render
Copy link

render bot commented Jan 27, 2021

Your Render PR Server URL is https://cugetreg-pr-10.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c08pvtlc2rvke9nign9g.

@new5558 new5558 self-assigned this Jan 27, 2021
@suphon-t
Copy link
Member

Deploy failed 😢
image

@new5558
Copy link
Member Author

new5558 commented Jan 27, 2021

Deploy failed 😢
image

Fixed @paphonb

suphon-t
suphon-t requested changes Jan 27, 2021
View reviewed changes
@suphon-t
Copy link
Member

On mobile so not going to comment about the broken layout, but the image here is stretched. Maybe changing object-fit to cover would be better?
Screenshot_20210128-010721.jpg

@new5558 new5558 requested a review from suphon-t January 28, 2021 05:28
suphon-t
suphon-t reviewed Jan 28, 2021
View reviewed changes
@suphon-t
Copy link
Member

Btw the emojis are broken.
Screen Shot 2564-01-28 at 15 30 16

@new5558
Copy link
Member Author

new5558 commented Jan 28, 2021

Btw the emojis are broken.
Screen Shot 2564-01-28 at 15 30 16

Windows 10 Sucks for dev

saenyakorn
saenyakorn requested changes Jan 28, 2021
View reviewed changes
Copy link
Member

@saenyakorn saenyakorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ปล.​ GenEd เขียนว่า GenEd นะ ไม่ใช่ Gened ;-;

@suphon-t
Copy link
Member

Windows 10 Sucks for dev

@new5558 macbookpro.com

@new5558
Copy link
Member Author

new5558 commented Jan 29, 2021

Windows 10 Sucks for dev

@new5558 macbookpro.com

Me will not use git emoji la na. :(

@suphon-t suphon-t mentioned this pull request Jan 29, 2021
Closed
@suphon-t
Copy link
Member

LGTM apart from this and this.

@suphon-t
Copy link
Member

Windows 10 Sucks for dev

@new5558 macbookpro.com

Me will not use git emoji la na. :(

FYI, copying from gitmoji.dev works fine for me. No need to manually type emojis.

suphon-t
suphon-t requested changes Jan 31, 2021
View reviewed changes
Copy link
Member

@suphon-t suphon-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reminder: this thread and this thread.

@new5558 new5558 mentioned this pull request Jan 31, 2021
Closed
@new5558 new5558 force-pushed the feat/announcementCard branch from 39970aa to 2b79aef Compare January 31, 2021 14:40
@new5558
Copy link
Member Author

new5558 commented Jan 31, 2021

Rebased to add newly merged theme color to GenedChip

@new5558 new5558 requested review from suphon-t and natTP January 31, 2021 14:40
suphon-t
suphon-t approved these changes Jan 31, 2021
View reviewed changes
Copy link
Member

@suphon-t suphon-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/components/GenEdChip/utils.ts
({
[GenEd.HU]: theme.palette.highlight.pink[700],
[GenEd.IN]: theme.palette.highlight.purple[700],
[GenEd.SC]: theme.palette.secondaryRange[900],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@saenyakorn @natTP should this be yellow or not?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For other GenEdChip we use 700 but for SC we use 900 that highlight[900] is not exist (700 is too bright )

This way is ok

saenyakorn
saenyakorn approved these changes Jan 31, 2021
View reviewed changes
Copy link
Member

@saenyakorn saenyakorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after using theme for borderRadius

@new5558
Copy link
Member Author

new5558 commented Jan 31, 2021

waiting for @saenyakorn @natTP to confirm color before merge

@new5558 new5558 merged commit f9e4051 into dev Jan 31, 2021
@new5558 new5558 deleted the feat/announcementCard branch January 31, 2021 15:09
@github-actions
Copy link
Contributor

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saenyakorn saenyakorn saenyakorn approved these changes

@suphon-t suphon-t suphon-t approved these changes

@saengowp saengowp Awaiting requested review from saengowp

@natTP natTP Awaiting requested review from natTP

Assignees

@new5558 new5558

Labels
Ready for review released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@new5558 @suphon-t @saenyakorn @natTP